Conversation
…gs no longer needs a toggle, key-value bubble is just a custom clunky debugger thing that has gone unused
bcb37
reviewed
Apr 9, 2025
| private versionService: VersionService | ||
| ) { | ||
| if (this.environment.featureFlagNavToggle) { | ||
| this.addFeatureFlagsLink(); |
Collaborator
There was a problem hiding this comment.
Do we still need the addFeatureFlagsLink() method? Doesn't look like it was called from anywhere else?
bcb37
reviewed
Apr 9, 2025
| providers: [ | ||
| { provide: ENV, useValue: environment }, | ||
| provideAppInitializer(() => { | ||
| const initializerFn = getEnvironmentConfig(inject(HttpClient), inject(ENV)); |
Collaborator
There was a problem hiding this comment.
Both inject() and provideAppInitializer() are now unused and can be removed from the imports
bcb37
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
environment.json setup replaced by new infrastructure setup, feature-flags is permanent now so no longer needs a frontend toggle, key-value bubble is just a custom clunky debugger thing that has gone unused.