Adventure: graceful map load failure and fix merfolkpool teleport case#10387
Open
vanja-ivancevic wants to merge 1 commit intoCard-Forge:masterfrom
Open
Adventure: graceful map load failure and fix merfolkpool teleport case#10387vanja-ivancevic wants to merge 1 commit intoCard-Forge:masterfrom
vanja-ivancevic wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
Teleport to a missing map file infinite-looped in TileMapScene.act(): nextMap was cleared after load(), so an exception left nextMap populated and the same failed load retried every frame with no way out. Clear nextMap before load(), wrap in try/catch, and call MapStage.exitDungeon on failure to return the player to the world map. Mirrors the existing pattern in WorldStage.loadPOI. Fix merfolkpool_6.tmx teleport referencing merfolkpool_6b.tmx when the actual file is merfolkpool_6B.tmx. Works on macOS/Windows but breaks on Linux case-sensitive filesystems, triggering the infinite-loop bug above. Applied to both the common copy and the Shandalar Old Border copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TileMapScene.act():nextMapwas cleared afterload(), so a thrown exception leftnextMappopulated and the same failed load retried every frame with no way for the player to escape.nextMapbefore callingload(), wrap in try/catch, and callMapStage.exitDungeonon failure to return the player to the world map. Mirrors the existing pattern inWorldStage.loadPOI.merfolkpool_6.tmxteleport referencingmerfolkpool_6b.tmxwhen the actual file ismerfolkpool_6B.tmx. Works on macOS/Windows but breaks on Linux case-sensitive filesystems, triggering the infinite-loop bug above. Applied to both thecommoncopy and theShandalar Old Bordercopy.