Conversation
Author
|
douenergy
force-pushed
the
bigquery-col-alias
branch
from
ec9739f to
8dedb1b
Compare
goldmedal
reviewed
Mar 24, 2025
Author
|
@goldmedal Thank you for the review. I have addressed your comments. I agree that encoding the column name is a better idea. Also, I will add a test case that includes a special character column name in the where clause. |
goldmedal
approved these changes
Mar 25, 2025
goldmedal
left a comment
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @douenergy. looks good to me 👍
I leave some minor suggestions.
|
Thanks @douenergy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Canner/wren-engine#1089
Rationale for this change
Add an additional unparser rule for every dialect to allow dialects to override column aliases.
What changes are included in this PR?
Rewrite BigQuery column aliases.
Are these changes tested?
In datafusion/sql/tests/cases/plan_to_sql.rs
roundtrip_statement_with_dialect.