Skip to content

Firefly-1924: Add Legend support#1920

Open
robyww wants to merge 1 commit intodevfrom
FIREFLY-1924-legend
Open

Firefly-1924: Add Legend support#1920
robyww wants to merge 1 commit intodevfrom
FIREFLY-1924-legend

Conversation

@robyww
Copy link
Contributor

@robyww robyww commented Mar 5, 2026 •
edited
Loading

Firefly-1924: Add Legend Support

  • added a legend on hips and images
  • new xs size for button
  • added selection in embedded components
  • added shortTitle for MOCs
  • some refactor and clean up
  • Renamed a couple of files to better reflect their function

ife PR: https://github.com/IPAC-SW/irsa-ife/pull/459

Testing

@robyww robyww added this to the 2026.1 milestone Mar 5, 2026
@robyww robyww self-assigned this Mar 5, 2026
@robyww robyww force-pushed the FIREFLY-1924-legend branch 3 times, most recently from 60f97ab to 752f899 Compare March 6, 2026 21:24
@robyww robyww marked this pull request as ready for review March 6, 2026 21:43
@robyww robyww requested review from kpuriIpac and lrebull March 6, 2026 21:43
@robyww robyww force-pushed the FIREFLY-1924-legend branch from 752f899 to 26ab615 Compare March 13, 2026 18:57
@robyww robyww requested a review from jaladh-singhal March 13, 2026 19:10
@lrebull
Copy link
Contributor

lrebull commented Mar 13, 2026

Nice!
DCE doesn't have the "details" button thingey in the legend - deliberate or accidental?
IRSA Viewer in general does have it, but the DCE tab within IV is also missing it.
The last iteration would tell you in the legend if the MOC was loading, and that was a really nice feature. It doesn't seem to be there anymore.

@robyww
Copy link
Contributor Author

robyww commented Mar 13, 2026

DCE doesn't have the "details" button thingey in the legend - deliberate or accidental?

I am not showing the details button when the MOC is used for a search interface, like dce, spherex, or euclid. For coverage views I enable it.

@robyww
Copy link
Contributor Author

robyww commented Mar 13, 2026

The last iteration would tell you in the legend if the MOC was loading, and that was a really nice feature. It doesn't seem to be there anymore.

I will look at this

@lrebull
Copy link
Contributor

lrebull commented Mar 13, 2026

are these not search interfaces?

Screenshot 2026-03-13 at 12 41 25 PM Screenshot 2026-03-13 at 12 41 20 PM

jaladh-singhal
jaladh-singhal reviewed Mar 17, 2026
View reviewed changes
@robyww robyww force-pushed the FIREFLY-1924-legend branch 3 times, most recently from 4470715 to fa56af2 Compare March 17, 2026 20:20
@lrebull
Copy link
Contributor

lrebull commented Mar 18, 2026

that is really, really nice. i love it!

jaladh-singhal
jaladh-singhal approved these changes Mar 18, 2026
View reviewed changes
Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - just minor comments.

Tested - works great in all different modes - fits, embedded hips, coverage, etc.

src/firefly/js/visualize/ui/RightSidePvDecoration.jsx Outdated

export const VisInlineToolbarView = memo( (props) => {
const {pv, showDelete,deleteVisible, topOffset=0}= props;
export const RightSidePvDecoration = memo( (props) => {
Copy link
Member

@jaladh-singhal jaladh-singhal Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should minimize naming components based on position/layout since they may move in future, it should rather be based on children components. How about "PlotStatusAndControls" or something like that? (status for warning, legends and controls for remove button)

src/firefly/js/visualize/ui/SelectAreaUIComponents.jsx Outdated
Comment on lines +188 to +189
? 'Choose search area: click and draw circle on map'
: 'Choose search area: click and draw rectangle on map' );
Copy link
Member

@jaladh-singhal jaladh-singhal Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have other shapes that may get added in future, maybe explicitly check for SelectedShape.rect and default to just "Choose search area: click and draw region on map"

@robyww
Firefly-1924: Add Legend support
77ee6ff 
- Added a legend on hips and images
- New xs size for button
- Added selection in embedded components
- Added shortTitle for MOCs
- Some refactor and clean up
- Renamed a couple of files to better reflect their function
- includes some reponse from several rounds of feedback
@robyww robyww force-pushed the FIREFLY-1924-legend branch from fa56af2 to 77ee6ff Compare March 18, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaladh-singhal jaladh-singhal jaladh-singhal approved these changes

@kpuriIpac kpuriIpac Awaiting requested review from kpuriIpac

@lrebull lrebull Awaiting requested review from lrebull

Assignees

@robyww robyww

Labels

enhancement

Projects

None yet

Milestone

2026.1

Development

Successfully merging this pull request may close these issues.

3 participants

@robyww @lrebull @jaladh-singhal