Skip to content

Fix#193 - InfoURL Style#194

Merged
TheWitness merged 5 commits intodevelopfrom
infourl
Feb 10, 2026
Merged

Fix#193 - InfoURL Style#194
TheWitness merged 5 commits intodevelopfrom
infourl

Conversation

@TheWitness
Copy link
Member

This feature allows the InfoURL to be customizable from both the Link and Node dialogs.

browniebraun
browniebraun previously approved these changes Feb 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable “Info URL Style” so the editor can generate Info URLs for nodes/links that point either to the classic multi-graph view or the time graph view.

Changes:

  • Added a new weathermap_infourl_style plugin setting and exposed it to the editor UI via a JS variable.
  • Updated the editor’s graph picker logic to generate Info URLs based on the configured style.
  • Refactored display_graphs() query to use a prepared LIKE parameter and added autocomplete_rows limiting logic.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
weathermap-cacti-plugin-editor.php Exposes the weathermap_infourl_style config to JS (infoUrlStyle).
setup.php Adds the new “Info URL Style” configuration setting.
lib/editor.inc.php Updates graph autocomplete SQL building and LIMIT handling.
js/editor.js Uses infoUrlStyle to choose the generated Info URL target format.
configs/simple.conf Updates example config, including InfoURL examples and IMAGEURI.
CHANGELOG.md Documents the new feature (with a minor typo).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

browniebraun
browniebraun previously approved these changes Feb 10, 2026
@TheWitness TheWitness merged commit bcf2726 into develop Feb 10, 2026
4 checks passed
@TheWitness TheWitness deleted the infourl branch February 10, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants