Merged
Conversation
browniebraun
previously approved these changes
Feb 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable “Info URL Style” so the editor can generate Info URLs for nodes/links that point either to the classic multi-graph view or the time graph view.
Changes:
- Added a new
weathermap_infourl_styleplugin setting and exposed it to the editor UI via a JS variable. - Updated the editor’s graph picker logic to generate Info URLs based on the configured style.
- Refactored
display_graphs()query to use a preparedLIKEparameter and addedautocomplete_rowslimiting logic.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| weathermap-cacti-plugin-editor.php | Exposes the weathermap_infourl_style config to JS (infoUrlStyle). |
| setup.php | Adds the new “Info URL Style” configuration setting. |
| lib/editor.inc.php | Updates graph autocomplete SQL building and LIMIT handling. |
| js/editor.js | Uses infoUrlStyle to choose the generated Info URL target format. |
| configs/simple.conf | Updates example config, including InfoURL examples and IMAGEURI. |
| CHANGELOG.md | Documents the new feature (with a minor typo). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
browniebraun
previously approved these changes
Feb 10, 2026
browniebraun
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows the InfoURL to be customizable from both the Link and Node dialogs.