Skip to content

CI workflow and CS fixer updates#198

Merged
TheWitness merged 6 commits intoCacti:developfrom
bmfmancini:csfixer
Feb 15, 2026
Merged

CI workflow and CS fixer updates#198
TheWitness merged 6 commits intoCacti:developfrom
bmfmancini:csfixer

Conversation

@bmfmancini
Copy link
Member

This pull request introduces four new custom agent definitions to the .github/agents directory, each designed to handle a specific area of expertise within the project. These agents are described in markdown files and include clear instructions, capabilities, and tool access. The main themes are the introduction of specialized agents for triage, code quality, PHP development, and MySQL/MariaDB database administration.

New Agent Definitions:

Agent Coordination and Routing:

  • Added a Triage Agent (triage_agent.md.agent.md) that receives user requests, analyzes them, and delegates tasks to specialized agents using explicit routing rules and a deterministic matching strategy. The agent includes detailed instructions, sample routing rules, and a delegation payload template.

Code Quality and Development:

  • Introduced a Code Quality Specialist agent (code-quality.agent.md) focused on code review, refactoring, testing, documentation, performance optimization, and security best practices for a LAMP stack with JavaScript frontend.
  • Added a PHP Developer agent (php-developer.agent.md) specializing in PHP code development, debugging, optimization, and adherence to PSR-12 standards, with references to Cacti project functions and documentation.

Database Administration:

  • Created a MySQL/MariaDB Database Administrator agent (mysql-mariadb.agent.md) to assist with database management, query optimization, troubleshooting, backup/recovery, security, and scripting, including references to built-in Cacti DB functions and relevant documentation.

Copilot AI review requested due to automatic review settings February 14, 2026 02:13
@bmfmancini bmfmancini changed the title Csfixer CI workflow and CS fixer updates Feb 14, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request performs comprehensive code quality improvements across the Monitor plugin codebase, primarily implementing PHP-CS-Fixer style changes. Additionally, it introduces CI/CD infrastructure and GitHub Copilot agent definitions. Despite the PR title "Csfixer" suggesting code style fixes, the description emphasizes agent definitions, which represents a minor discrepancy.

Changes:

  • Modernized PHP syntax: converted array() to [], /* */ to // comments, else if to elseif
  • Removed trailing whitespace and blank lines across all PHP files
  • Improved code formatting: operator spacing, string concatenation, function call alignment
  • Added GitHub Actions CI workflow for integration testing across PHP 8.1-8.4 and MariaDB 10.6
  • Introduced GitHub Copilot instructions and specialized agent definitions (triage, code quality, PHP developer, MySQL/MariaDB DBA)
  • Added vendor/ to .gitignore

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
setup.php Modernized array syntax, comment style, control structures, and spacing throughout plugin setup code
poller_monitor.php Applied consistent formatting to poller script including array syntax and comment style updates
monitor.php Comprehensive formatting improvements to main UI controller following same patterns
themes/*/index.php Removed trailing blank lines
sounds/index.php Removed trailing blank line
locales/*/index.php Removed trailing blank lines
index.php Removed trailing blank line
.gitignore Added vendor/ directory exclusion
.github/workflows/plugin-ci-workflow.yml New CI workflow for integration testing
.github/copilot-instructions.md New Copilot guidance document
.github/agents/*.agent.md New agent definitions for triage, code quality, PHP development, and database administration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TheWitness and others added 3 commits February 13, 2026 21:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@TheWitness TheWitness merged commit d9d2565 into Cacti:develop Feb 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants