NOT FOR MERGE - VSS 6.0 preparation #476
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Jaegervall <[email protected]>
Fixing some regressions Signed-off-by: Erik Jaegervall <[email protected]>
Signed-off-by: Erik Jaegervall <[email protected]>
erikbosch
commented
Dec 18, 2025
| # Should be empty since no custom directives defined | ||
| assert len(custom_directives) == 0 | ||
| # But is 1 from graphql-core 3.2.7 onwards due to "oneOf" | ||
| assert len(custom_directives) == 1 |
Collaborator
Author
There was a problem hiding this comment.
@jdacoello - can you check if this is expected when updating graphlql-core
erikbosch
commented
Dec 18, 2025
| "types-setuptools>=75.3.0.20241107", | ||
| ] | ||
|
|
||
| [tool.coverage.run] |
Collaborator
Author
There was a problem hiding this comment.
@sschleemilch - this was needed to get coverage right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR highlights changes prepared for 6.0. We plan on releasing the final 6.0 after the meeting Jan 13th