Dlt devel protocol v2 review #801
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A detail technical document is constructed for the DLT Protocol v2 support in the upcoming Major Release Version dlt-daemon v3.0.1 Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
- Provide example packages to fit with dlt protocol v2 - Provide utilities (dlt-control-v2, dlt-receive-v2) so that messages in dlt protocol v2 can be captured and proceeded Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
- Declare DLTv2 APIs to fit with dlt protocol v2 - Provide new parameters for ECUid, Appid, Ctxid flexible lengths in v2 format Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
- Implement internal/common functions to handle DLTv2 format data - Introduce DLTv2 functions to proceed control messages, client messages, injection messages Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
- Implement DLTv2 Gateway APIs to handle DLTv2 message format Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
- Provide basic DLTv2 message format handling in dlt user library - Enable DLT Applications to use DLT Protocol under multiplexing concept (DLTv1 and DLTv2 applications can connect to the same resources) Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
Provide basic DLTv2 message format handling in dlt common APIs and shared resources Signed-off-by: Erik Bergh <[email protected]> Signed-off-by: Suyash Chandra (Consultant) <[email protected]> Signed-off-by: JayaprasadTJ <[email protected]> Signed-off-by: LUU QUANG MINH <[email protected]>
minminlittleshrimp
force-pushed
the
dlt_devel_protocol_v2_review
branch
3 times, most recently
from
da4b610 to
aa5a7f6
Compare
Closed
- Enable fail fast -Wfatal-error - Fix abuse casting for data - Fix wrong function usages - Fix critical potential use-after-free of msgv2.headerbufferv2 - Rebase and solve merge conflicts Signed-off-by: LUU QUANG MINH <[email protected]>
minminlittleshrimp
force-pushed
the
dlt_devel_protocol_v2_review
branch
from
aa5a7f6 to
f12094d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done from Bosch:
• Split changes into several topics: Core, Protocols, Utils, Doc, etc
• Commits shall base on the splitting plan (we shall have 5-8 commits only) then squash into 1 final commit (if it makes sense)
To keep the review easier for both sides, during Bosch review phases we have not been requesting any rework from Volvo.
Bosch shall now apply our rework, since this topic is huge and for first 2 rounds reviewing we have to perform every LoC (Line of Code) in detail review/understanding due to quality standard (For example, mis-using dlt_daemon_v2 -> v2 for protocol not for daemon). Last, PR shall be updated by a rework version from Bosch, it is now set back to DRAFT. Bosch shall make sure commits being signed off by any contributors from Volvo and Bosch.
Next actions from Bosch:
PR shall be merged when all below features from dlt protocol v2 satisfied [2]: