Skip to content

Comment mentions #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssddanbrown merged 12 commits into from
Dec 18, 2025
Merged

Comment mentions #5944

ssddanbrown merged 12 commits into from
Dec 18, 2025
+1,184 −124

Conversation

@ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Dec 8, 2025 •
edited
Loading

Related to #560.

Todo

  • Finish off editor UI.
  • Address remaining todos in code changes
  • Add lookup for users
    • Limit to those with ability to create/update comments for now.
  • Back-end comment parsing
  • Notification on mention
  • Notification preferences - Add option for comment mentions.
  • Test cases for back-end functionality.
    • Add test to cover new user search endpoint.
  • Stress-test & fix editor/front-end behaviour
  • Dark mode test
  • Chromium test

Considerations

  • How do we handle mention changes on comment updates.
    • We're tracking mentions via the database, and only mention if a new mention is added, so we don't notify for prior mentions (even if a notification was not sent before).
  • Do we need rate limiting to prevent spam like page update notifications.
    • Avoid for now, but should be able to track/add via history system if found to be needed upon user feedback.
  • Are these useful if we don't opt-in users to them by default?
    • We will opt in those with notification permissions by default. Add extra further consideration for admin-level user notification management in future.

Doc Updates

  • Update advisory - Anyone with comment create/update will technically be able to access a list of system users.
  • Update advisory - Any users with a "Receive & manage notifications" role permission will be opted-in to comment mention notifications by default.

@ssddanbrown ssddanbrown self-assigned this Dec 8, 2025
@ssddanbrown
Mentions: Added new endpoint, Built editor list display
9bf9ae9
@ssddanbrown
Lexical: Changed mention to be a decorator node
1e768ce 
Allows better selection.
Also updated existing decorator file names to align with classes so
they're easier to find.
Also aligned/fixed decorator constuctor/setup methods.
@ssddanbrown
JS: Swapped livereload lib for esbuild livereload setup
147ff00
@ssddanbrown
Comment Mentions: Added keyboard nav, worked on design
e2f91c2
@ssddanbrown
Comment Mentions: Added core back-end logic
221c6c7 
- Added new user notification preference, opt-in by default
- Added parser to extract mentions from comment HTML, with tests to
  cover.
- Added notification and notification handling

Not yet tested, needs testing coverage.
@ssddanbrown
Merge branch 'development' into comment_mentions
4f76047
@ssddanbrown
Comment Mentions: Added tests to cover back-end functionality
48cdaab
@ssddanbrown
Mentions: Added coverage for mentions search endpoint
3d9aba7
@ssddanbrown
Esbuild & Mentions: Updated interaction stability and build system
90fc02c 
- Updated esbuild system to be module, and fixed build command.
- Reverted module use in package.json by default as this impacted test
  runs/files.
- Updated mention user select:
  - To look better in dark mode.
  - To not remove text after on select.
  - To properly revert/restore focus on enter or cancel.
@ssddanbrown ssddanbrown added this to the 🎅 Next Feature Release milestone Dec 17, 2025
@ssddanbrown
Comment Mentions: Fixed and tweaks during review of changes
51f9b63 
- Added advisory on role permission form to advise which allow listing
  of users/roles.
- Updated database config to avoid PHP8.5 deprecation.
- Tweaked migration to remove unused index.
- Fixed test namespace.
@ssddanbrown ssddanbrown merged commit a941d1b into development Dec 18, 2025
22 checks passed
@ssddanbrown ssddanbrown deleted the comment_mentions branch December 18, 2025 17:55
@ssddanbrown ssddanbrown mentioned this pull request Dec 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ssddanbrown ssddanbrown

Labels

📖 Docs Update 💻 Front-End 🏭 Back-End 🛠️ Enhancement

Milestone

🎅 Next Feature Release

Development

Successfully merging this pull request may close these issues.

2 participants

@ssddanbrown