Merged
Conversation
gagdiez
commented
Mar 24, 2025
Closed
rubenmarcus
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed a couple of things on the
bitte-ai/walletpackage:package.jsonsome very small inconsistency when declaring whatcjsandesmfiles are exported.jsextension on thebitte-wallet.tsimports [note bellow]signAndSendTransaction, which was creating atransactionthat the wallet does not need3.1. Removed
createTransactionas it is not neededlocalStoragekeys, prependingbitte:to them, to avoid collisions with MyNearWallet[note] In all honesty, I was expecting
tsupto take care of this, but in the spirit of not changing the code much I have opted for the simplest solution.