Skip to content

fix: injected wallet#5

Merged
rubenmarcus merged 5 commits intoBitteProtocol:mainfrom
gagdiez:main
Mar 24, 2025
Merged

fix: injected wallet#5
rubenmarcus merged 5 commits intoBitteProtocol:mainfrom
gagdiez:main

Conversation

@gagdiez
Copy link
Copy Markdown

@gagdiez gagdiez commented Mar 24, 2025

I have changed a couple of things on the bitte-ai/wallet package:

  1. Fixed on package.json some very small inconsistency when declaring what cjs and esm files are exported
  2. I have included the .js extension on the bitte-wallet.ts imports [note bellow]
  3. I fixed signAndSendTransaction, which was creating a transaction that the wallet does not need
    3.1. Removed createTransaction as it is not needed
  4. Changed the name of the localStorage keys, prepending bitte: to them, to avoid collisions with MyNearWallet

[note] In all honesty, I was expecting tsup to take care of this, but in the spirit of not changing the code much I have opted for the simplest solution.

@gagdiez gagdiez marked this pull request as draft March 24, 2025 12:39
Comment thread src/bitte-wallet.ts
@gagdiez gagdiez changed the title fix: esm module fix: injected wallet Mar 24, 2025
@rubenmarcus rubenmarcus mentioned this pull request Mar 24, 2025
@gagdiez gagdiez marked this pull request as ready for review March 24, 2025 16:24
@rubenmarcus rubenmarcus merged commit 3437ccc into BitteProtocol:main Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants