-
Notifications
You must be signed in to change notification settings - Fork 116
Add content around address formatting and validation #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds two paragraphs to the Address page in the Glossary. - Visual formatting of addresses - Validation of addresses I could not find any good info on exactly how well address can be validated. In a recent podcast, someone said that in some formats, it is possible to identify which character is wrong. Maybe someone with more technical knowledge in this area could chime in. Closes #107, closes #806
|
Excellent! I love the green check / red exclamation point. Simple design features that can mean the world. One small addition/question: is it a best practice to present addresses using monospaced fonts? |
|
Something I forgot to add is that showing the first 4 characters of an address is not enough to actually compare anything. All SegWit and Taproot addresses start with "bc1q" and "bc1p" respectively. That means the first 4 characters convey no unique information. So if an address is shortened, it should be "XXXX XXXX...XXXX" and not "XXXX...XXXX". @paulosacramento I don't think mono space fonts are 100% necessary at all times. I used mono space in the modal because that is specifically for investigating the address closely. |
|
I think it is reasonable to recommend Bitcoin on-chain addresses to be displayed with a type of font that was specifically designed to improve readability and distinction between letters and numbers. |
sbddesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overall agree with the text and it looks very nice. I left an inline suggestion to clarify that segwit and taproot addresses have the advanced error detection you were trying to describe.
The majority of these images feature the old legacy addresses. Maybe it would be good to work in some segwit or taproot addresses? While we definitely need to encourage compatibility with sending to these legacy addresses, it just seems weird to have the old address format so prevalent in the imagery.
Bosch-0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks for the feedback. I added notes about mono space fonts, updated the images to SegWit addresses, and resolved the conflict. |
sbddesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Adds two paragraphs to the Address page in the Glossary.
Also added a visual for the address reuse paragraph.
I could not find any good info on exactly how well address can be validated. In a recent podcast, someone said that in some formats, it is possible to identify which character is wrong. Maybe someone with more technical knowledge in this area could chime in.
This is only about on-chain addresses. We could consider what validation techniques we need in lightning in a separate issue (if there are any, haven't thought about it yet).
Closes #107, closes #806