apacheGH-30622: [GAC-11] Put Timestream ODBC driver into Arrow repository without code style fixes#7
Merged
alinaliBQ merged 14 commits intoGAC-odbc-driverfrom Nov 28, 2023
Conversation
* fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests
* code uploading * fix cppcheck failure (#1) * fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests * verify signer works fine * fix singer could not find the installer package * change signed installer name * fix linux package wrong name issue * restore signer flag * add .gitignore * remove unneeded files * remove unneeded files * address comments * add version to installer name * remove not needed file
…mation improvement (#4) * fix occasional test failure * document update * add check for credentials leak
* pass driver info to Timestream using user agent * add log for user agent setting
Signed-off-by: forestmvey <forestv@bitquilltech.com>
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
github-actions
bot
added
Component: C++
Component: FlightRPC
Component: Documentation
labels
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/timestream-odbc-no-code-lint-fixes
branch
from
dd4a531 to
572a830
Compare
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/timestream-odbc-no-code-lint-fixes
branch
3 times, most recently
from
6ccb0f4 to
c70f3cf
Compare
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/timestream-odbc-no-code-lint-fixes
branch
3 times, most recently
from
d3b82f0 to
b53be45
Compare
…ODBC driver seed disable integration tests from running. The win-build.yml file is copied from Amazon Timestream ODBC driver code.
Note that rest of lint errors are not solved yet.
* integration tests are disabled. * allow build scripts to be run through `chmod`.
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/timestream-odbc-no-code-lint-fixes
branch
from
b53be45 to
4ac9ff1
Compare
Ubuntu 20.04 Debug Build Test Results Check
|
Windows 2022 (x64) Debug Build Code Coverage Test Results Check
|
jduo
approved these changes
Nov 27, 2023
jduo
left a comment
jduo
left a comment
There was a problem hiding this comment.
Migrated code + auto-generated review comments only.
MacOS Big Sur 11 Debug Build Code Coverage Unit and Integration Test Result
|
alinaliBQ
deleted the
alinaliBQ/GAC-11/timestream-odbc-no-code-lint-fixes
branch
justing-bq
reviewed
Jan 12, 2024
| on: | ||
| push: | ||
| paths: | ||
| - '.github/workflows/win-build.yml' |
There was a problem hiding this comment.
I assume we want mac-build.yml here?
Author
There was a problem hiding this comment.
Yes, good catch here. I have created Jira to fix this.
justing-bq
reviewed
Jan 12, 2024
| on: | ||
| push: | ||
| paths: | ||
| - '.github/workflows/win-build.yml' |
justing-bq
reviewed
Jan 12, 2024
| on: | ||
| push: | ||
| paths: | ||
| - '.github/workflows/win-build.yml' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Integration Apache 2.0 licensed AWS Timestream ODBC driver into the Arrow repository.
What changes are included in this PR?
cpp/src/arrow/flight/sql. This seed (files undercpp/src/arrow/flight/sql/amazon-timestream-odbc-driver/*) does not need to reviewed because its code has not been changed, with the exception of CMAKE files, which have been modified byarchery lint --cmake-format --fix..github/workflows/*.Are these changes tested?
Unit tests for Timestream ODBC driver are preserved. Integration tests are not covered as tests for the driver will be added as functionalities are developed.
Are there any user-facing changes?
No.