This repository was archived by the owner on Apr 20, 2021. It is now read-only.
Use swagger dump as json schemas source#245
Merged
sanpii merged 3 commits intoBehatch:masterfrom Mar 22, 2018
gpenverne:json-schema-swagger-validation
Merged
Use swagger dump as json schemas source#245sanpii merged 3 commits intoBehatch:masterfrom gpenverne:json-schema-swagger-validation
sanpii merged 3 commits intoBehatch:masterfrom
gpenverne:json-schema-swagger-validation
Conversation
sanpii
suggested changes
Mar 21, 2018
Member
sanpii
left a comment
sanpii
left a comment
There was a problem hiding this comment.
Thank you for work. Please also update the i18n/en.xliff.dist file with the now definitions.
| */ | ||
| public function theJsonShouldNotBeValidAccordingToTheSwaggerSchema($dumpPath, $schemaName) | ||
| { | ||
| try { |
Member
There was a problem hiding this comment.
The Asserter::not() method done exactly the same thing. Please use it.
| @@ -1,3 +1,5 @@ | |||
| @JSON | |||
Contributor
Author
There was a problem hiding this comment.
Used locally to only run JSON behat test. Removed it.
sanpii
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Then the JSON should be valid according to swagger :dumpPath dump schema :schemaName@Then the JSON should not be valid according to swagger :dumpPath dump schema :schemaName