This repository was archived by the owner on Apr 20, 2021. It is now read-only.
add JSON node should match context#234
Merged
sanpii merged 3 commits intoBehatch:masterfrom Dec 19, 2017
Merged
Conversation
sanpii
suggested changes
Dec 19, 2017
Member
sanpii
left a comment
sanpii
left a comment
There was a problem hiding this comment.
Could you also update i18n/en.xliff.dist file?
|
|
||
| $actual = $this->inspector->evaluate($json, $node); | ||
|
|
||
| if (!((bool) preg_match($pattern, $actual))) { |
Member
There was a problem hiding this comment.
Useless cast, simply test:
if (preg_match(…) === 0)
Contributor
Author
|
Done |
sanpii
approved these changes
Dec 19, 2017
Member
|
Merged, thank you 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First, thanks for your work. I was looking for a way to check that a json node matched a pattern and only found the "JSON should be valid according to this schema" way which seemed a little overkill when you only want to test one JSON node. So this should be used to test a single node against a regex.