This repository was archived by the owner on Apr 20, 2021. It is now read-only.
Fix Symfony 3.4/4.0 compatibility#228
Merged
sanpii merged 2 commits intoBehatch:masterfrom Nov 22, 2017
Merged
Conversation
Member
|
Thank you 😃 Can you remove php 7.2 from travis configuration, I had already a branch for that https://github.com/Behatch/contexts/tree/php72 |
Contributor
Author
|
@sanpii done |
Contributor
Author
|
We're able to run our test suite with this patch and Symfony 3.4. Can you tag a new release @sanpii? |
Member
|
@dunglas I am trying to fix tests with php 7.2 and I can create they (2.8 and 3.0). |
Member
|
@dunglas bug fixed. I am starting to write changelog for the next release. |
Contributor
Author
|
great, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe that a subsequent PR will be mandatory because currently, Behat find no scenario when using Symfony 3.4/4.0.