Fix http headers

[themizzi]

Two things: 1) it stores the client so headers are lost between calls to setHttpHeaders. 2) setHttpHeaders handles Content headers appropriately.

[elkangaroo]

We just stumbled upon this header bug, trying to set Content-Type header with symfony2 session (Behat\Symfony2Extension) will set HTTP_CONTENT_TYPE instead of CONTENT_TYPE.

This PR needs some clean-up, though, as the changes from commit 65d4a10 are no longer needed (already implemented with #209).

@themizzi can you please update this PR or create a new PR with only commit 7742b0a (Content-Header Fix)?

[themizzi]

@elkangaroo I have reverted the unnecessary commit.

[elkangaroo]

Awesome, thx @themizzi 👍

[razbakov]

See #218. It also contains tests and some improvements.

[silasjoisten]

ping @OskarStark

[OskarStark]

See #218. It also contains tests and some improvements.

#218 should be merged instead of this, as it contains tests.
@razbakov can you apply the comments/feedback in your PR to get it merged?

[sanpii]

For me, a good PR could be this one with headers.feature.

#218 does two other things could be discussed separetly.

[OskarStark]

sounds good, unless you don't get any feedback I could submit a new one with this fix and the feature

[sanpii]

Now #218 is ok for me.

[OskarStark]

@sanpii can you please merge and release this? all checks are green now

[sanpii]

#218 merged.

[OskarStark]

Yay, thank you @sanpii 🎉
Can you create a release? Thank you

[sanpii]

@OskarStark I would like fix travis build before.

[OskarStark]

any news here?

Is this PR (which is not release yet) maybe related to the travis problem?
Behat/MinkExtension#311