Skip to content
This repository was archived by the owner on Apr 20, 2021. It is now read-only.

Fix RequestHeaders#157

Closed
arosslau wants to merge 2 commits intoBehatch:masterfrom
arosslau:requestHeaderFix
Closed

Fix RequestHeaders#157
arosslau wants to merge 2 commits intoBehatch:masterfrom
arosslau:requestHeaderFix

Conversation

@arosslau
Copy link
Copy Markdown

Hey,

This PR fixes setting Headers before sending a request in the request-class.
Actually the Client got instantiated on each Methodcall of a Requestinstance which resulted in setting headers before a request had no effect.

e.g.

$request->setHttpHeader(xxx, yyy); // invokes __call in request which first instaniates a new client
$request->send(xxx); // here you've got a fresh instance of the client, too

@sanpii
Copy link
Copy Markdown
Member

sanpii commented Feb 19, 2016

Can you add a test for this bug?

@arosslau
Copy link
Copy Markdown
Author

Hey, Sorry for the late response. Sure, i will rebase to master and add some tests in next few days.

Ps: Is there any Documentaion of how to setup the environment? :-)

@sanpii
Copy link
Copy Markdown
Member

sanpii commented Mar 23, 2016

Is there any Documentaion of how to setup the environment?

You can follow instructions from travis configuration: https://github.com/Behatch/contexts/blob/master/.travis.yml#L29-L38

@sanpii sanpii added this to the 3.0 milestone Mar 2, 2017
@sanpii sanpii closed this Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants