This repository was archived by the owner on Apr 20, 2021. It is now read-only.
Closed
Conversation
3c36b6b to
fedcc9e
Compare
Member
|
Can you add a test for this bug? |
Author
|
Hey, Sorry for the late response. Sure, i will rebase to master and add some tests in next few days. Ps: Is there any Documentaion of how to setup the environment? :-) |
Member
You can follow instructions from travis configuration: https://github.com/Behatch/contexts/blob/master/.travis.yml#L29-L38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR fixes setting Headers before sending a request in the request-class.
Actually the Client got instantiated on each Methodcall of a Requestinstance which resulted in setting headers before a request had no effect.
e.g.