Document Pager/Poller next_link type usage across spector tests#836
Closed
Document Pager/Poller next_link type usage across spector tests#836
Conversation
Copilot
AI
changed the title
[WIP] Investigate spector tests next_link implementations
Document Pager/Poller next_link type usage across spector tests
Feb 4, 2026
Member
|
I only wanted the analysis for design decisions and didn't intend for a PR to be opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation
Analyzed all Pager and Poller implementations in spector tests to identify which use
UrlvsStringfornext_linkcontinuation tokens.Findings
Pagers: 1 uses String, rest use Url
String-based (continuation tokens):
payload/pageable/pageable_server_driven_pagination_continuation_token_client.rs- all 6 functions usePagerState<String>Url-based (standard pagination):
PagerState<Url>Pollers: All use Url
PollerState<Url>Pattern
Models serialize
next_linkasOption<String>for JSON. Implementation diverges at state machine level:Continuation token pattern appropriately uses opaque strings; URL-based pagination uses typed
Urlobjects.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.