Fix DataTestMethod attributes, OrdinalIgnoreCase dictionary comparer, and explicit blob delimiter#1317
Merged
torosent merged 2 commits intotorosent/update-depsfrom Mar 13, 2026
Merged
Conversation
…icit delimiter Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update all NuGet dependencies to latest versions
Fix DataTestMethod attributes, OrdinalIgnoreCase dictionary comparer, and explicit blob delimiter
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses four review comments from #1316 where the dependency upgrade introduced subtle correctness issues.
Changes
[DataTestMethod]restored for parameterized tests — The upgrade incorrectly replaced[DataTestMethod]with[TestMethod]on all[DataRow]-driven tests; MSTest requires[DataTestMethod]for test discovery/execution to work. Fixed across 62 tests inAzureStorageScenarioTests.csand 1 inAzureStorageScaleTests.cs.StringComparer.OrdinalIgnoreCaseinOrchestrationSessionManager.cs—ToDictionaryAsyncwas called withcomparer: null(case-sensitive), inconsistent with theOrdinalIgnoreCasede-duplication applied to instance IDs earlier in the same method. Missed lookups could result from casing mismatches.GetBlobsByHierarchyAsync—default(resolves tonull) was passed as the delimiter, which changes SDK behavior vs. an explicit"/". Now uses a named argument for clarity.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.