Skip to content

Fix DataTestMethod attributes, OrdinalIgnoreCase dictionary comparer, and explicit blob delimiter#1317

Merged
torosent merged 2 commits intotorosent/update-depsfrom
copilot/sub-pr-1316
Mar 13, 2026
Merged

Fix DataTestMethod attributes, OrdinalIgnoreCase dictionary comparer, and explicit blob delimiter#1317
torosent merged 2 commits intotorosent/update-depsfrom
copilot/sub-pr-1316

Conversation

Copy link

Copilot AI commented Mar 13, 2026

Addresses four review comments from #1316 where the dependency upgrade introduced subtle correctness issues.

Changes

  • [DataTestMethod] restored for parameterized tests — The upgrade incorrectly replaced [DataTestMethod] with [TestMethod] on all [DataRow]-driven tests; MSTest requires [DataTestMethod] for test discovery/execution to work. Fixed across 62 tests in AzureStorageScenarioTests.cs and 1 in AzureStorageScaleTests.cs.

  • StringComparer.OrdinalIgnoreCase in OrchestrationSessionManager.csToDictionaryAsync was called with comparer: null (case-sensitive), inconsistent with the OrdinalIgnoreCase de-duplication applied to instance IDs earlier in the same method. Missed lookups could result from casing mismatches.

// Before
await instances.ToDictionaryAsync(o => o.State.OrchestrationInstance.InstanceId, comparer: null, cancellationToken);

// After
await instances.ToDictionaryAsync(o => o.State.OrchestrationInstance.InstanceId, comparer: StringComparer.OrdinalIgnoreCase, cancellationToken);
  • Explicit delimiter in GetBlobsByHierarchyAsyncdefault (resolves to null) was passed as the delimiter, which changes SDK behavior vs. an explicit "/". Now uses a named argument for clarity.
// Before
.GetBlobsByHierarchyAsync(BlobTraits.Metadata, BlobStates.None, default, sanitizedInstanceId, default)

// After
.GetBlobsByHierarchyAsync(BlobTraits.Metadata, BlobStates.None, delimiter: "/", sanitizedInstanceId, default)

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…icit delimiter

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copilot AI changed the title [WIP] Update all NuGet dependencies to latest versions Fix DataTestMethod attributes, OrdinalIgnoreCase dictionary comparer, and explicit blob delimiter Mar 13, 2026
Copilot AI requested a review from torosent March 13, 2026 22:39
@torosent torosent marked this pull request as ready for review March 13, 2026 22:47
@torosent torosent merged commit f68157e into torosent/update-deps Mar 13, 2026
2 checks passed
@torosent torosent deleted the copilot/sub-pr-1316 branch March 13, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants