Skip to content

Azure.Communication.Email 1.1.0 - 2025-09-01#43090

Merged
annatisch merged 25 commits intomainfrom
feature/ddouglas/communication-2025-09-01-stable-inlineimages
Oct 15, 2025
Merged

Azure.Communication.Email 1.1.0 - 2025-09-01#43090
annatisch merged 25 commits intomainfrom
feature/ddouglas/communication-2025-09-01-stable-inlineimages

Conversation

@ddouglas-msft
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings September 23, 2025 00:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Communication Email SDK to version 1.1.0 with API version 2025-09-01. The update adds support for the contentId property on email attachments, allowing consumers to reference attachments in the email body using the cid scheme.

  • Version bump from 1.0.1b1 to 1.1.0 with new API version 2025-09-01
  • Addition of contentId property support for email attachments
  • Generated code updates for improved type annotations and error handling

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

File Description
azure/communication/email/_version.py Updated package version to 1.1.0
CHANGELOG.md Added release notes for new contentId feature
swagger/README.md Updated API specification reference and package version
_generated/ files Auto-generated code updates for new API version

@ddouglas-msft ddouglas-msft force-pushed the feature/ddouglas/communication-2025-09-01-stable-inlineimages branch from 0ee30c5 to 3d67d8e Compare September 23, 2025 05:24
@ddouglas-msft ddouglas-msft force-pushed the feature/ddouglas/communication-2025-09-01-stable-inlineimages branch from 3d67d8e to f1ae476 Compare September 23, 2025 06:16
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-communication-email

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddouglas-msft - it's great to see this SDK get an update!
We should try to use this opportunity to bring the SDK in line with latest code-gen practice.

Would you be able to remove the _generated directory, and generate the code directly into the azure/communication/email directory? Then we can use the _patch.py files to update the clients as needed.
Some existing examples of this structure can be seen in:

This will make maintenance easier, and will also make the transition to typespec code gen simpler.
We should be able to make this a non-breaking transition, because this SDK has no public models.

@natekimball-msft
Copy link
Member

@annatisch I noticed that the MyPy and Pylint stages are still failing, but it's not in the email area of the SDK code. Should I fix these issues up in this PR, as well?

@natekimball-msft
Copy link
Member

Thanks @natekimball-msft - please revert that last commit - we will not block this PR on the pylint/mypy status of the other Communications SDKs, so we shouldn't try to fix them in this PR. I will try to re-review the Email changes today.

We also need to get this PR merged before Email SDK can be released: #42925

Got it, I'll revert. If that commit winds up fixing those MyPy/Pylint errors in the pipeline stage, should I push those changes to a new PR to help out the other teams, or just leave them alone?

@annatisch
Copy link
Member

Thanks! I think opening a new PR for the Chat and Rooms fixes will be great. All the _shared modules should be resolved by the PR I linked above (hopefully we'll get that merged this week), and the SMS SDK already has another PR open to regenerate to the latest API version, so we'll resolve that one there. The JobRouter and Messages SDKs will require code-regeneration rather than manual edits - so we'll just leave those for now until they next have an API version bump

@natekimball-msft natekimball-msft force-pushed the feature/ddouglas/communication-2025-09-01-stable-inlineimages branch from b493238 to 247bfa0 Compare October 7, 2025 22:09
@natekimball-msft
Copy link
Member

I went ahead and reverted that commit, so we're back to the previous state and this PR is ready for re-review.

I also went ahead and created a new PR branch for the chat & rooms MyPy/Pylint fixes: #43283

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one last thing!

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks so much for the refactor work! Much appreciated!

@natekimball-msft
Copy link
Member

natekimball-msft commented Oct 10, 2025

@annatisch Assuming this PR is good to go, how do we go about getting it merged, seeing as how we have the MyPy/Pylint issues in the pipeline? Update: Looks like there are a couple of test runs failing, but it's unrelated to changes in this PR.

@annatisch
Copy link
Member

I seems we're starting to see some test failures....
@mccoyp are you able to confirm whether this is an incompatibility of the record/playback with 3.14? Or is there's something specific to this SDK?

@mccoyp
Copy link
Member

mccoyp commented Oct 14, 2025

@annatisch It looks like the issue is that Scott's fix to ignore Accept-Encoding headers is removed by this library when set_default_session_settings is called in its conftest.py. Tests should pass again if we either remove that default setting function call or re-exclude the header afterward in azure-communication-messages/tests/conftest.py:

@pytest.fixture(scope="session", autouse=True)
def start_proxy(test_proxy):
    set_default_session_settings()
    add_oauth_response_sanitizer()
    # Ignore Accept-Encoding because it can cause matching issues on Python 3.14
    set_custom_default_matcher(excluded_headers="Accept-Encoding")

@natekimball-msft
Copy link
Member

@annatisch @mccoyp I've updated the recorded tests and conftest.py, and from what I can tell, our service tests are no longer failing. It looks like there are failing tests outside of our code, however. What can we do to get our code merged?

@annatisch
Copy link
Member

/check-enforcer override

@annatisch annatisch merged commit ef96495 into main Oct 15, 2025
23 of 27 checks passed
@annatisch annatisch deleted the feature/ddouglas/communication-2025-09-01-stable-inlineimages branch October 15, 2025 20:57
@annatisch
Copy link
Member

Done! Thank you so much @natekimball-msft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants