Azure.Communication.Email 1.1.0 - 2025-09-01#43090
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Communication Email SDK to version 1.1.0 with API version 2025-09-01. The update adds support for the contentId property on email attachments, allowing consumers to reference attachments in the email body using the cid scheme.
- Version bump from 1.0.1b1 to 1.1.0 with new API version 2025-09-01
- Addition of
contentIdproperty support for email attachments - Generated code updates for improved type annotations and error handling
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| azure/communication/email/_version.py | Updated package version to 1.1.0 |
| CHANGELOG.md | Added release notes for new contentId feature |
| swagger/README.md | Updated API specification reference and package version |
| _generated/ files | Auto-generated code updates for new API version |
0ee30c5 to
3d67d8e
Compare
3d67d8e to
f1ae476
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
annatisch
left a comment
There was a problem hiding this comment.
Thanks @ddouglas-msft - it's great to see this SDK get an update!
We should try to use this opportunity to bring the SDK in line with latest code-gen practice.
Would you be able to remove the _generated directory, and generate the code directly into the azure/communication/email directory? Then we can use the _patch.py files to update the clients as needed.
Some existing examples of this structure can be seen in:
This will make maintenance easier, and will also make the transition to typespec code gen simpler.
We should be able to make this a non-breaking transition, because this SDK has no public models.
sdk/communication/azure-communication-email/azure/communication/email/_email_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_email_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_operations/__init__.py
Show resolved
Hide resolved
|
@annatisch I noticed that the MyPy and Pylint stages are still failing, but it's not in the email area of the SDK code. Should I fix these issues up in this PR, as well? |
sdk/communication/azure-communication-email/samples/send_email_to_multiple_recipients_sample.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_email_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_patch.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/aio/_patch.py
Outdated
Show resolved
Hide resolved
...communication/azure-communication-email/azure/communication/email/aio/_email_client_async.py
Outdated
Show resolved
Hide resolved
Got it, I'll revert. If that commit winds up fixing those MyPy/Pylint errors in the pipeline stage, should I push those changes to a new PR to help out the other teams, or just leave them alone? |
|
Thanks! I think opening a new PR for the Chat and Rooms fixes will be great. All the |
b493238 to
247bfa0
Compare
|
I went ahead and reverted that commit, so we're back to the previous state and this PR is ready for re-review. I also went ahead and created a new PR branch for the chat & rooms MyPy/Pylint fixes: #43283 |
...communication/azure-communication-email/azure/communication/email/_operations/_operations.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_patch.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/aio/_patch.py
Outdated
Show resolved
Hide resolved
...communication/azure-communication-email/azure/communication/email/_operations/_operations.py
Outdated
Show resolved
Hide resolved
annatisch
left a comment
There was a problem hiding this comment.
LGTM - thanks so much for the refactor work! Much appreciated!
sdk/communication/azure-communication-email/apiview-properties.json
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-email/azure/communication/email/_client.py
Show resolved
Hide resolved
|
@annatisch Assuming this PR is good to go, how do we go about getting it merged, seeing as how we have the MyPy/Pylint issues in the pipeline? Update: Looks like there are a couple of test runs failing, but it's unrelated to changes in this PR. |
|
I seems we're starting to see some test failures.... |
…able-inlineimages
|
@annatisch It looks like the issue is that Scott's fix to ignore Accept-Encoding headers is removed by this library when @pytest.fixture(scope="session", autouse=True)
def start_proxy(test_proxy):
set_default_session_settings()
add_oauth_response_sanitizer()
# Ignore Accept-Encoding because it can cause matching issues on Python 3.14
set_custom_default_matcher(excluded_headers="Accept-Encoding") |
…images' of https://github.com/Azure/azure-sdk-for-python into feature/ddouglas/communication-2025-09-01-stable-inlineimages
|
@annatisch @mccoyp I've updated the recorded tests and conftest.py, and from what I can tell, our service tests are no longer failing. It looks like there are failing tests outside of our code, however. What can we do to get our code merged? |
|
/check-enforcer override |
|
Done! Thank you so much @natekimball-msft! |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines