Skip to content

Comments

[Pipeline] Users/seseicht/adjust publish#1472

Merged
MariusStorhaug merged 14 commits intoAzure:issue/1607from
SeSeicht:users/seseicht/adjustPublish
Jun 26, 2022
Merged

[Pipeline] Users/seseicht/adjust publish#1472
MariusStorhaug merged 14 commits intoAzure:issue/1607from
SeSeicht:users/seseicht/adjustPublish

Conversation

@SeSeicht
Copy link
Contributor

@SeSeicht SeSeicht commented Jun 3, 2022

Description

#1085

These change will allow to publish the artifacts in a different subscripion than the validation modules.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr changed the title Users/seseicht/adjust publish [Pipeline] Users/seseicht/adjust publish Jun 3, 2022
@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines [cat] publishing category: publishing labels Jun 3, 2022
@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Jun 3, 2022
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for introducing this new feature, very much needed. A couple of comments from my side:

  1. Discuss if the same SP should have permissions on both validation and publish subscription or if we need to support 2 different SP/serviceConnections as well. This is often the case with customers requiring an SP to be mapped to a specific subscription
  2. If going with supporting 2 SP this PR will closely relate to PR #1452 (see also comment to issue #1465)
  3. Additional documentation needed and depending on the 2 points above

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to draft to be merged after publishing the next release and after team agreement on all secret names

@eriqua eriqua marked this pull request as draft June 14, 2022 08:04
@MariusStorhaug MariusStorhaug changed the base branch from main to issue/1607 June 26, 2022 13:48
@MariusStorhaug MariusStorhaug marked this pull request as ready for review June 26, 2022 13:50
@MariusStorhaug
Copy link
Member

Merging to a full implementation branch for 'overhauling' authentication

@MariusStorhaug MariusStorhaug merged commit 47d86a0 into Azure:issue/1607 Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] pipelines category: pipelines [cat] publishing category: publishing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants