MAINT: Refactoring General Identifiers and ScorerIdentifier #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rlundeen2 merged 14 commits into Azure:main from rlundeen2:users/rlundeen/2026_01_23_scorer_identifier

Jan 27, 2026

Contributor

rlundeen2 commented Jan 26, 2026 •

edited

Loading

As we make the move to use frozen dataclasses for Identifiers, I moved ScorerIdentifier to use this pattern.

Removed dict references to ScorerIdentifier
Made Registry Metadata subclass Identifier
Made an Identifiable class so that other component classes (targets, attacks, etc.) can use the same pattern as scorers
Moved Identifiers to their own module (deleting models/identifiers)

Tests

Added SQL Azure Integration round trip test for ScorerIdentifier
Integration tests pass (other than a few targets) at e71dbe6

rlundeen2 added 5 commits

January 23, 2026 19:10


          scorer identifier update

097d0b6


          identifier location update

2fae929


          fixing logic

e4b874f


          Updates to pipe ScorerIdentifier through

80405a7


          moving usage to non-deprecated

f12753a

jsong468 reviewed

View reviewed changes

pyrit/identifiers/identifier.py Show resolved Hide resolved

rlundeen2 added 3 commits

January 26, 2026 14:16


          moving normalize shim up a level

d8b127e


          Not storing empty values

2ae1811


          test fix

1045abe

jsong468 reviewed

View reviewed changes

pyrit/identifiers/identifier.py Outdated Show resolved Hide resolved

rlundeen2 added 2 commits

January 26, 2026 15:22


          pr feedback

ffa678a


          Not part of my pr woops

92e03b9

jsong468 reviewed

View reviewed changes

pyrit/identifiers/identifier.py Outdated Show resolved Hide resolved

jsong468 reviewed

View reviewed changes

pyrit/models/message_piece.py Show resolved Hide resolved

jsong468 reviewed

View reviewed changes

pyrit/registry/instance_registries/scorer_registry.py Outdated Show resolved Hide resolved

jsong468 reviewed

View reviewed changes

pyrit/score/score_utils.py Show resolved Hide resolved

jsong468 reviewed

View reviewed changes

pyrit/identifiers/identifier.py Outdated Show resolved Hide resolved

varunj-msft reviewed

View reviewed changes

tests/unit/score/test_scorer_identifier.py Outdated Show resolved Hide resolved

varunj-msft reviewed

View reviewed changes

pyrit/identifiers/scorer_identifier.py Show resolved Hide resolved

rlundeen2 added 4 commits

January 26, 2026 19:03


          pr feedback

e71dbe6


          updating api.rst

95af60e


          updating api.rst

d82dc92


          test fix

2a7e690

varunj-msft approved these changes

View reviewed changes

Contributor

varunj-msft left a comment

Comments addressed and changes made. PR looks good!

jsong468 reviewed

View reviewed changes

pyrit/datasets/seed_datasets/remote/vlsu_multimodal_dataset.py Show resolved Hide resolved

jsong468 approved these changes

View reviewed changes

rlundeen2 merged commit d2af298 into Azure:main

20 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet