Merged
Conversation
zhiyuanliang-ms
requested review from
Eskibear,
juniwang,
linglingye001,
rossgrambo and
zhenlan
Member
|
LGTM to update accordingly if it's a breaking change of ReadOnlyMap declaration from TS 5.6.x. No problem for JS developers. |
Member
Author
I updated the dependency in package.json. We required the minimum version to 5.6.3 |
linglingye001
approved these changes
Oct 22, 2024
linglingye001
pushed a commit
that referenced
this pull request
Oct 24, 2024
zhiyuanliang-ms
added a commit
that referenced
this pull request
Oct 31, 2024
* Adds additional undefined check (#104) * add loadCdn * revert change * fix lint * update to loadFromCdn & reuse load method * update * update * add js file extension to imports (#109) * update typescript version (#112) * add requestTracingOptions (#114) * Version bump 1.1.1 (#115) * bump up version 1.1.1 * update --------- Co-authored-by: Ross Grambo <rossgrambo@microsoft.com> Co-authored-by: linglingye001 <143174321+linglingye001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
There is a breaking change in 5.6.x: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#what’s-new-since-the-beta-and-rc
The interface of
ReadonlyMapchanged. OurAzureAppConfigurationimplements it.You may see some read underscore in vscode, this is because the built-in typescript version is 5.6+
Visible change
Actually, there won't be visible change for users who consume our package. The compiled file will be written in javascript and there will be no types there. So the compiled outputs will be the same.