[WIP] Update expression extensions refactor and fix typos#200
Merged
[WIP] Update expression extensions refactor and fix typos#200
Conversation
…tion Co-authored-by: BlaiseD <7595209+BlaiseD@users.noreply.github.com>
BlaiseD
approved these changes
Feb 24, 2026
BlaiseD
added a commit
that referenced
this pull request
Feb 24, 2026
* Refactor expression extensions; fix typos and errors
- Consolidated all expression extension methods into ExpressionExtensions.cs; deleted VisitorExtensions.cs.
- Added ExpressionHelpers.cs for member access and parameter replacement helpers.
- Fixed resource typos ("deledate" → "delegate", "rempa" → "map").
- Added new error message for invalid type mappings.
- Updated TypeMappingsManager to throw on mismatched Expression<> types and always add type mappings for argument pairs.
- Cleaned up XpressionMapperVisitor.cs, fixed VisitParameter bug, and removed unused ConvertTypesIfNecessary.
- Updated unit tests for corrected error messages.
- Improves code organization, error clarity, and maintainability.
* [WIP] Update expression extensions refactor and fix typos (#200)
* Initial plan
* Add test for Expression source with non-Expression destination validation
Co-authored-by: BlaiseD <7595209+BlaiseD@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BlaiseD <7595209+BlaiseD@users.noreply.github.com>
* Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fix typo in exception message assertion in test
Corrected "Invalis type mappings" to "Invalid type mappings" in the assertion for AddTypeMapping_ExpressionSourceNonExpressionDest_ThrowsArgumentExcep test to ensure accurate exception message validation.
* Fix typos in resource comments and summaries
Corrected "Invalis" to "Invalid" in resource string summaries and XML comments. Also fixed "destinationTyp;" to "destinationType" in resource comments for clarity. No functional changes made.
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BlaiseD <7595209+BlaiseD@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddTypeMapping_ExpressionSourceNonExpressionDest_ThrowsArgumentExceptionto verify validation logic✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.