Fix or suppress compiler warnings (Qt 5.15 w/MinGW)#818
Merged
stonedDiscord merged 13 commits intomasterfrom Jul 29, 2022
Merged
Fix or suppress compiler warnings (Qt 5.15 w/MinGW)#818stonedDiscord merged 13 commits intomasterfrom
stonedDiscord merged 13 commits intomasterfrom
Conversation
Closed
in1tiate
changed the title
Contributor
|
There is one issue, not MingW related, where MSVC is unable to parse the QMAKE flag we put in the pro file. If that isn't needed anymore this would also work perfectly fine for both compilers. |
Member
|
You should run an interactive rebase and drop the screenshake related commits now that those have been merged. |
Merged
Member
|
squashed merge commit looks good actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends #812
Resolves #799, #800, and should allow us to go forward with #801 if I'm not mistaken