Use event filters instead of subclassing QLineEdit and QPlainTextEdit#587
Merged
Use event filters instead of subclassing QLineEdit and QPlainTextEdit#587
Conversation
oldmud0
reviewed
Aug 30, 2021
oldmud0
requested changes
Aug 31, 2021
| ui_evidence_description->appendPlainText(f_evi.description); | ||
| ui_evidence_description->setReadOnly(true); | ||
| ui_evidence_description->setToolTip(tr("Double-click to edit...")); | ||
| ui_evidence_description->setToolTip(tr("Click the pencil to edit...")); |
Member
There was a problem hiding this comment.
maybe I am being too meticulous, but if the evidence_edit widget wasn't loaded in the theme, the old tooltip text should be used
Member
Author
There was a problem hiding this comment.
the old tooltip text will be inaccurate because I removed the functionality to double click to edit
Member
There was a problem hiding this comment.
oh, now it shows that you deleted the double click handler. ok
oldmud0
approved these changes
Aug 31, 2021
Crystalwarrior
added a commit
that referenced
this pull request
Feb 18, 2022
Fix evidence editing regressions caused by #587 Fix issues with "ok" button detecting itself as "changes from the server" Fix "ok" button remaining after you press it once, allowing you to spam evidence update packets by spamclicking it
Crystalwarrior
added a commit
that referenced
this pull request
Feb 19, 2022
commit 17b6f63 Author: Alex Noir <Varsash@gmail.com> Date: Sat Feb 19 18:19:22 2022 +0300 Fix editing the image name not showing the "ok" button commit 42b2a8a Author: Alex Noir <Varsash@gmail.com> Date: Sat Feb 19 17:59:56 2022 +0300 Fix evidence image button getting set to disabled commit 798617f Author: Alex Noir <Varsash@gmail.com> Date: Sat Feb 19 00:40:26 2022 +0300 Polish up the evidence system so it's a single-click editing Fix evidence editing regressions caused by #587 Fix issues with "ok" button detecting itself as "changes from the server" Fix "ok" button remaining after you press it once, allowing you to spam evidence update packets by spamclicking it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.