Skip to content

Added paths option to resolve stdlib imports in IDE's #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcodeIO merged 1 commit into from
Jun 12, 2019
Merged

Added paths option to resolve stdlib imports in IDE's #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion std/assembly.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
"noLib": true,
"allowJs": false,
"typeRoots": [ "types" ],
"types": [ "assembly" ]
"types": [ "assembly" ],
"baseUrl": ".",
"paths": {
"*": [
"./assembly/*"
]
}
}
}
1 change: 1 addition & 0 deletions std/assembly/rt/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ declare function __visit(ref: usize, cookie: i32): void;
declare function __visit_globals(cookie: u32): void;
declare function __visit_members(ref: usize, cookie: u32): void;
declare function __allocArray(length: i32, alignLog2: usize, id: u32, data?: usize): usize;
declare const ASC_RTRACE: boolean;
Copy link
Member

@MaxGraey MaxGraey Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this declaration better include here I guess

Copy link
Member

@dcodeIO dcodeIO Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this is actually not present at all without --use ASC_RTRACE=1, and meant to be used as isDefined(ASC_RTRACE).

Copy link
Contributor Author

@willemneal willemneal Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is my I thought it best to put here since this is the folder where it is referenced and so IDE's will use it. And it seemed like an internal definition so I didn't want to put it in the higher level file.

2 changes: 1 addition & 1 deletion std/assembly/rt/pure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { onincrement, ondecrement, onfree, onalloc } from "./rtrace";
// B: buffered

// @ts-ignore: decorator
@inline const BUFFERED_MASK: u32 = 1 << (sizeof<u32>() * 8 - 1);
@inline const BUFFERED_MASK: u32 = 1 << ((sizeof<u32>() * 8) - 1);
Copy link
Member

@MaxGraey MaxGraey Jun 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this unnecessary. Multiply already have bigger precedence than subtraction

Copy link
Contributor Author

@willemneal willemneal Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but the syntax confused my IDE.

Screen Shot 2019-06-07 at 1 06 00 PM

// @ts-ignore: decorator
@inline const COLOR_BITS = 3;
// @ts-ignore: decorator
Expand Down