-
-
Notifications
You must be signed in to change notification settings - Fork 584
appimagetool: Use mksquash from path relative to main executable #579
Copy link
Copy link
Closed
Labels
Description
openSUSE is packaging appimagetool, and since appimagetool needs a patched version of mksquashfs (e.g., for supporting offsets) it is not desired to have the patched one on the normal $PATH where it would interfere with the normal mksquashfs of the distribution.
- Do we need any
mksquashfspatches other than the offset functionality, which since has been merged in the upstreammksquashfs? If offsets are the only reason for needing a privatemksquashfscurrently, then maybe openSUSE could just get the latestmksquashfsinto the distribution and remove the need for the private one - If that is not possible and we still need a private one, we should have
appimagetoollook for a path relative to itself first, like/$(dirname($(cat /proc/self/exe))/../lib/appimagetool/mksquashfsand, if present, give it preference over the one on the regular$PATH
That would remove the need for the patch needed in openSUSE currently:
https://build.opensuse.org/package/view_file/OBS:AppImage/AppImageKit/own-mksquashfs.patch?expand=1
Reference:
electron-userland/electron-builder#1478 (comment)
Reactions are currently unavailable