Update RoundedBarChartRenderer.kt#363
Closed
Paget96 wants to merge 1 commit intoAppDevNext:masterfrom
Closed
Conversation
Changelog - RoundedBarChartRenderer Improvements Added: Auto Full Radius Mode Introduced a new setUseAutoFullRadius(true) function that enables automatic calculation of full corner radius for bars. When enabled, the radius dynamically adapts based on the bar’s current screen width and height, ensuring fully rounded corners regardless of zoom level or chart scale. This feature improves visual consistency, especially when zooming in/out, as the rounding remains proportional to each bar’s dimensions. Fixed: Marker Not Showing on Highlight Previously, markers were not appearing when bars were highlighted due to missing positional metadata. This has been resolved by ensuring setHighlightDrawPos(...) is called inside drawHighlighted(), which correctly updates the Highlight object with the marker's draw position. Now, the custom and other markers will be properly displayed above highlighted bars, even when using this renderer.
Collaborator
|
There is an issue with pull requests from a fork, which prevent a properly running CI. The reason is a missing token on fork side to be able to push on screenshot compare job. @Paget96 Please rebase on recent master, to be able to run the CI at least on successful jobs |
hannesa2
force-pushed
the
master
branch
6 times, most recently
from
53b7426 to
4f5395a
Compare
hannesa2
force-pushed
the
master
branch
5 times, most recently
from
c522fac to
c61f056
Compare
Collaborator
|
I rebased this pull request to #602 |
hannesa2
force-pushed
the
master
branch
4 times, most recently
from
159d22d to
7dc3b14
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog - RoundedBarChartRenderer Improvements
Added: Auto Full Radius Mode
Introduced a new setUseAutoFullRadius(true) function that enables automatic calculation of full corner radius for bars.
When enabled, the radius dynamically adapts based on the bar’s current screen width and height, ensuring fully rounded corners regardless of zoom level or chart scale.
This feature improves visual consistency, especially when zooming in/out, as the rounding remains proportional to each bar’s dimensions.
Fixed: Marker Not Showing on Highlight
Previously, markers were not appearing when bars were highlighted due to missing positional metadata.
This has been resolved by ensuring setHighlightDrawPos(...) is called inside drawHighlighted(), which correctly updates the Highlight object with the marker's draw position.
Now, the custom and other markers will be properly displayed above highlighted bars, even when using this renderer.