Skip to content

Fix sequential loading when using multiple envs#12

Merged
taufeeque9 merged 7 commits intosokobanfrom
tf/fix-load-seq-multiple-envs
Jun 27, 2024
Merged

Fix sequential loading when using multiple envs#12
taufeeque9 merged 7 commits intosokobanfrom
tf/fix-load-seq-multiple-envs

Conversation

@taufeeque9
Copy link
Collaborator

No description provided.

@taufeeque9 taufeeque9 requested a review from rhaps0dy June 27, 2024 23:04
Copy link

@rhaps0dy rhaps0dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thikn one line is UB

@taufeeque9 taufeeque9 requested a review from rhaps0dy June 27, 2024 23:42
Copy link

@rhaps0dy rhaps0dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for explaining

@taufeeque9 taufeeque9 merged commit 9432d14 into sokoban Jun 27, 2024
@taufeeque9 taufeeque9 deleted the tf/fix-load-seq-multiple-envs branch June 27, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants