Skip to content

[PWGDQ,PWGJE] speed up runMCGen and reshape table #14520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zjxiongOvO wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[PWGDQ,PWGJE] speed up runMCGen and reshape table #14520

zjxiongOvO wants to merge 6 commits into from
+117 −80

Conversation

@zjxiongOvO
Copy link
Contributor

@zjxiongOvO zjxiongOvO commented Jan 16, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026 •
edited
Loading

O2 linter results: ❌ 1198 errors, ⚠️ 372 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title speed up runMCGen and reshape table [PWGDQ,PWGJE] speed up runMCGen and reshape table Jan 16, 2026
@alibuild alibuild mentioned this pull request Jan 16, 2026
Merged
@zjxiongOvO
Merge pull request #18 from alibuild/alibot-cleanup-14520
4207121 
[PWGDQ] Please consider the following formatting changes to AliceO2Group#14520
nzardosh
nzardosh reviewed Jan 16, 2026
View reviewed changes
PWGJE/Core/JetDQUtilities.h Outdated
candidate.deviationPairKF(), candidate.deviationxyPairKF(),
candidate.massKFGeoTop(), candidate.chi2overndfKFGeoTop(),
candidate.tauz(), candidate.tauxy(), candidate.lz(), candidate.lxy());
candidate.tauz(), candidate.tauxy(), -999., candidate.lz(), candidate.lxy());
Copy link
Collaborator

@nzardosh nzardosh Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zjxiongOvO , why do you fill this with a dummy value in the JE framework instead of doing candidate.tauxyPoleJpsiMass() ?

Copy link
Contributor Author

@zjxiongOvO zjxiongOvO Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, my original intention was to avoid impacting the workflows of other PWGs as much as possible, but I have already submitted a new PR to fix it

@alibuild
Copy link
Collaborator

alibuild commented Jan 16, 2026

Error while checking build/O2Physics/o2 for c04669b at 2026-01-16 19:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14520-slc9_x86-64/0/PWGJE/Core/JetDQUtilities.h:350:52: error: invalid use of non-static member function 'decltype(auto) o2::aod::reducedpair::TauxyPoleJpsiMass::tauxyPoleJpsiMass() const'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

datamodel pwgdq pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zjxiongOvO @alibuild @nzardosh