[PWGJE,EMCAL-670] emcalCorrectionTask: remove std::optional function … #11303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhemmer-cern
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa and
nzardosh
as code owners
|
O2 linter results: ❌ 11 errors, |
…params - std::optional can create copies, std::optional<T> const& can bind to temporaries and may copy. Instead we now use either directly a gsl::span, or pointers, if not using a span. - Save cluster energy in variable inside `fillClusterTable` as well as `clusterType` to reduce lookup time - Move the reserve call for `clustercells` inside `fillClusterTable` outside of the cluster loop to ensure large enough size ONCE before filling. - Similar for `fillAmbigousClusterTable`
Collaborator
Author
|
Local tests look good, this can be merged from my side. |
fjonasALICE
approved these changes
May 27, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 11, 2025
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Jun 12, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 12, 2025
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jul 16, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…params
fillClusterTableas well asclusterTypeto reduce lookup timeclustercellsinsidefillClusterTableoutside of the cluster loop to ensure large enough size ONCE before filling.fillAmbigousClusterTable