Skip to content

add alien SE #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Jan 12, 2021
Merged

add alien SE #5160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Framework/AnalysisSupport/src/AODJAlienReaderHelpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,19 @@ AlgorithmSpec AODJAlienReaderHelpers::rootFileReaderCallback()
std::string nextFileRead = info.file->GetPath();
if (currentFileRead != nextFileRead) {
currentFileRead = nextFileRead;
std::string monitoringInfo(currentFileRead);
monitoringInfo += ",";
monitoringInfo += std::to_string(info.file->GetSize());
#if __has_include(<TJAlienFile.h>)
auto alienFile = dynamic_cast<TJAlienFile*>(info.file);
if (alienFile) {
/// FIXME: get the JAlien stats
monitoringInfo += ",";
monitoringInfo += alienFile->GetSE();
Copy link
Member

@ktf ktf Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the problem with the metrics is not that GetSE() returns something which the monitoring backend does not understand as a properly formatted string? I will check.

Copy link
Collaborator Author

@jgrosseo jgrosseo Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the line which appears with LOGP looks proper: E.g. "alien:///alice/data/2015/LHC15o/000244918/pass5_lowIR/PWGZZ/Run3_Conversion/96_20201013-1346_child_1/0028/AO2D.root:/,631838549,ALICE::CERN::EOS"

Copy link
Collaborator Author

@jgrosseo jgrosseo Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, merge this, we can parse the log output if we don't get the logging up

}
#endif
monitoring.send(Metric{currentFileRead, "aod-file-read-path"}.addTag(Key::Subsystem, monitoring::tags::Value::DPL));
monitoring.send(Metric{monitoringInfo, "aod-file-read-info"}.addTag(Key::Subsystem, monitoring::tags::Value::DPL));
LOGP(INFO, "File read info: {}", monitoringInfo);
// TODO extend to publish at the end of the file (or on each TF?) the sizes read *per file*
}
}
monitoring.send(Metric{(double)ps.GetReadCalls(), "aod-tree-read-calls"}.addTag(Key::Subsystem, monitoring::tags::Value::DPL));
Expand Down