(O2-1813)[GPU] Rename double overloads for math functions #4871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLettrich
force-pushed
the
O2-1702-o2-mathutils
branch
from
c171c2a to
987d15d
Compare
davidrohr
reviewed
Nov 19, 2020
MichaelLettrich
force-pushed
the
O2-1702-o2-mathutils
branch
from
987d15d to
7ffd8ba
Compare
Collaborator
|
Great, now this runs into a problem with templates in OpenCL. Tried to apply a fix, let's seee... |
Collaborator
|
Shit, still not working, will try this locally later this week and provide a fix then. Sorry for this OpenCL mess. Have to file a bug report to clang about it. Last time they rejected a similar report because their behavior was "according to the OpenCL spec" but this behavior is a mess and in my opinion just broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double precision overloads for GPU functions (and the respective, calling functions) were renamed with a trailing
dto ensure that they are not used by accident.