Skip to content

PWGHF: Add Dplus variables and histograms #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgrosseo merged 1 commit into from
Dec 3, 2020
Merged

PWGHF: Add Dplus variables and histograms #4797

jgrosseo merged 1 commit into from
Dec 3, 2020

Conversation

@fcatalan92
Copy link
Contributor

@fcatalan92 fcatalan92 commented Nov 9, 2020

@vkucera @nzardosh @ginnocen Please have a look. In principle, it is ready to be merged

@fcatalan92 fcatalan92 mentioned this pull request Nov 9, 2020
Merged
vkucera
vkucera requested changes Nov 16, 2020
View reviewed changes
vkucera
vkucera requested changes Nov 16, 2020
View reviewed changes
@fcatalan92 fcatalan92 marked this pull request as ready for review November 18, 2020 17:08
@fcatalan92
Copy link
Contributor Author

fcatalan92 commented Nov 18, 2020

@vkucera @nzardosh @ginnocen Ready to be merged

vkucera
vkucera requested changes Nov 18, 2020
View reviewed changes
Analysis/DataModel/include/Analysis/HFSecondaryVertex.h Outdated
Comment on lines 139 to 140
Copy link
Collaborator

@vkucera vkucera Nov 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be there.

Copy link
Contributor Author

@fcatalan92 fcatalan92 Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It slipped in during the rebase. Fixed

@ginnocen ginnocen changed the title PWGHF: Add Dplus variables and histograms PWGHF: DO NOT MERGE YET, Add Dplus variables and histograms Nov 19, 2020
@jgrosseo jgrosseo marked this pull request as draft November 20, 2020 09:04
@jgrosseo
Copy link
Collaborator

jgrosseo commented Nov 20, 2020

@ginnocen I have changed to draft PR because you don't want to have it merged

@ginnocen
Copy link
Collaborator

ginnocen commented Nov 28, 2020

hi @fcatalan92, this PR looks fine to me. If there are no stoppers on your side, I would suggest you change the status to ready for review and we approve it.

@ginnocen ginnocen changed the title PWGHF: DO NOT MERGE YET, Add Dplus variables and histograms PWGHF: Add Dplus variables and histograms Nov 28, 2020
@fcatalan92 fcatalan92 marked this pull request as ready for review November 28, 2020 09:51
@fcatalan92 fcatalan92 requested a review from ginnocen as a code owner November 28, 2020 09:51
@fcatalan92
Copy link
Contributor Author

fcatalan92 commented Nov 28, 2020

Hi @ginnocen, it is ready to be merged

@ginnocen
Copy link
Collaborator

ginnocen commented Nov 28, 2020

hi @fcatalan92 perfect thanks. I will merge once the tests have passed. Cheers GM

@fcatalan92
Copy link
Contributor Author

fcatalan92 commented Nov 28, 2020 •
edited
Loading

hi @fcatalan92 perfect thanks. I will merge once the tests have passed. Cheers GM

Thanks, the current errors for build/AliceO2/O2/o2/macOS and build/O2/o2-dataflow are not related to this PR.
One is a CCDB test and the other is related to alice3 tracking (@mpuccio)

@ginnocen
Copy link
Collaborator

ginnocen commented Nov 28, 2020

hi @fcatalan92. Yes, indeed. I will have to see if I can force the merge even in presence of unrelated errors. If yes, I will do it otherwise Jan will have to do it. GM

@ginnocen ginnocen self-requested a review November 29, 2020 18:25
@jgrosseo jgrosseo merged commit 57c0ec5 into AliceO2Group:dev Dec 3, 2020
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
@fcatalan92 @jgrosseo
Add Dplus analysis variables and update Dplus task histograms (AliceO…
4554c81 
…2Group#4797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera requested changes

@ginnocen ginnocen ginnocen approved these changes

@iarsene iarsene Awaiting requested review from iarsene

@jgrosseo jgrosseo Awaiting requested review from jgrosseo

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fcatalan92 @jgrosseo @ginnocen @vkucera