Skip to content

ci(publish): build harness deps before running tests#6

Merged
khaliqgant merged 1 commit intomainfrom
fix/publish-harness-deps
Apr 15, 2026
Merged

ci(publish): build harness deps before running tests#6
khaliqgant merged 1 commit intomainfrom
fix/publish-harness-deps

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Apr 15, 2026

Summary

  • The publish workflow runs npm test -w @agent-assistant/harness before its dependency-aware build step, so harness's vitest can't resolve its workspace deps and @agent-assistant/surfaces@0.2.0 is blocked from publishing.
  • Adds a "Prepare harness test dependencies" step that mirrors .github/workflows/ci.yml: builds traits, memory, connectivity, coordination, and rebuilds turn-context (stale committed dist).
  • Connectivity and coordination are not in the publish matrix at all, so the later dependency-aware build step does not cover them.

Test plan

  • Ran the exact prep chain locally in a fresh worktree
  • npm test -w @agent-assistant/harness passes (32/32)
  • CI on this PR stays green

🤖 Generated with Claude Code


Open with Devin

The publish workflow runs `npm test -w @agent-assistant/harness` before
its dependency-aware build step, which fails because harness's vitest
needs the dists of its workspace deps (traits, memory, connectivity,
coordination, turn-context) to be present and fresh. Connectivity and
coordination are not in the publish matrix at all, and turn-context
ships with a stale committed dist.

Mirror the prep chain from .github/workflows/ci.yml so the test step
can resolve every workspace import. This unblocks publishing
@agent-assistant/surfaces@0.2.0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@khaliqgant khaliqgant merged commit 07e437e into main Apr 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant