[Phase 7] Complete Sharrow #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # activitysim/core/mp_tasks.py # activitysim/examples/prototype_mtc_extended/test/test_mtc_extended.py
i-am-sijia
reviewed
Jan 1, 2023
i-am-sijia
requested changes
Jan 2, 2023
Contributor
i-am-sijia
left a comment
i-am-sijia
left a comment
There was a problem hiding this comment.
Looks good to me! I only have three comments.
I tested the placeholder_sandag multi-zone model with Sharrow on my windows machine, it ran fine.
Co-authored-by: Sijia Wang <[email protected]>
# Conflicts: # activitysim/cli/run.py # activitysim/core/memory_sidecar.py # activitysim/core/mp_tasks.py
This reverts commit 6b52af2.
i-am-sijia
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes all other sharrow PR's, and contains a complete and integrated implementation of all Phase 7 tasks.
Published (draft) documentation is here: https://camsys.github.io/activitysim/feature-sharrow-tt