Revised handling of unknown warnings #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-W<some unknown warning>` is now (by default) a warning (not a fatal error) and `-Wno-<some unknown warning>` is ignored. This is what GCC and Clang do. This commit also introduces the `unknown-warning-option` warning, so that warnings about unknown warnings can be ignored (`-Wno-unknown-warning-option`) or turned into an error (`-Werror=unknown-warning-option`). This is what Clang does. Closes: #552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, unrecognized warning options
-Wsome-unknown-warningare fatal errors.As suggested in #552, this PR makes sure that
-Wsome-unknown-warningis a warning (by default), and that-Wno-some-unknown-warningis ignored. This is what GCC and Clang do.This commit also introduces the
unknown-warning-optionwarning, so that warnings about unknown warnings can be ignored (-Wno-unknown-warning-option) or turned into an error (-Werror=unknown-warning-option). This is what Clang does.Closes: #552