Conversation
sproshev
approved these changes
Sep 30, 2016
|
|
||
| dependencies { | ||
| testCompile 'junit:junit:4.12' | ||
| } No newline at end of file |
| for (int i = 0; i < capacity; i++) { | ||
| store[i] = new List(); | ||
| } | ||
| } |
There was a problem hiding this comment.
с отступами что-то не то, пробелы/табы?
| public boolean contains(String key) { | ||
| // true, если такой ключ содержится в таблице | ||
| int cellNumber = key.hashCode() % capacity; | ||
| return store[cellNumber].exists(key); |
There was a problem hiding this comment.
как минимум вычисление cellNumber стоило выделить в отдельный метод, но еще лучше, вынести в отдельный метод код:
int cellNumber = ...;
return store[cellNumber];
| for (int i = 0; i < capacity; i++) { | ||
| store[i] = new List(); | ||
| } | ||
| size = 0; |
There was a problem hiding this comment.
можно упростить конструктор, вызывая clear
| size = 0; | ||
| } | ||
|
|
||
| private class Entry { |
| } | ||
| } | ||
|
|
||
| private class List { |
| int hash; | ||
| String key, val; | ||
|
|
||
| Entry(String newKey, String newVal) { |
There was a problem hiding this comment.
почему у конструкторов нет модификаторов доступа?
| head = null; | ||
| } | ||
|
|
||
| private class Node { |
| @Test | ||
| public void testSize() { | ||
| org.junit.Assert.assertTrue("Size method " + | ||
| "returned incorrect value.", map.size() == 3); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.