Use ActivityIndicator for both iOS and Android#41
Closed
designblooz wants to merge 2 commits intoAPSL:masterfrom
Closed
Use ActivityIndicator for both iOS and Android#41designblooz wants to merge 2 commits intoAPSL:masterfrom
designblooz wants to merge 2 commits intoAPSL:masterfrom
Conversation
|
@alvaromb it looks like this PR fixes your comment on #38 (comment). Any chance you can merge it? You'll probably want to bump the minor |
Collaborator
|
I'm currently on family vacation, I'll ping you guys if I find some time today after dinner. Thanks! Enviado desde mi iPhone
|
Collaborator
|
Hi guys! Tested this and I'm ready to merge. Can you squash your commits? @designblooz |
Collaborator
|
Never mind, will merge in #42 Thanks for the changes!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
_renderInnerTextAndroidand_renderInnerTextiOSand use_renderInnerTextfor both platform, since current react native supportsActivityIndicatorin both platform.