fix: add WebRTC timeouts and fix auth/Apollo error handling#264
Merged
fix: add WebRTC timeouts and fix auth/Apollo error handling#264
Conversation
…rror handling Webrtc.ts: Add 10s timeouts to data channel open and peer connection promises. Remove unnecessary async from createPeer. Destroy peer on error. AuthStore.ts: Replace async Promise constructor with proper async/await. apollo.client.ts: Use continue instead of return so auth errors don't prevent other error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect()andcreatePeer()promises to prevent indefinite hangs. Remove unnecessaryasynckeyword fromcreatePeer. Destroy peer on error before rejecting.new Promise(async (resolve) => {...})anti-pattern with proper async/await to prevent swallowed rejectionsreturntocontinuein auth error handling so other GraphQL errors in the same response are still processedCloses 5stackgg/5stack-panel#388, 5stackgg/5stack-panel#389, 5stackgg/5stack-panel#390
Test plan