Skip to content

[Game Server] Async void anti-pattern & missing command input validation #402

@Flegma

Description

@Flegma

Summary

Code quality issues reducing reliability.

Findings

  • ReadySystem.cs — async void SendNotReadyMessage() causes unobserved exceptions. Should return Task.
  • Match.cs — command.ArgString passed to MapStatusStringToEnum without validation.

Impact

Silent failures from async void. Invalid command arguments cause unexpected behavior.

Suggested Fix

Change async void to async Task. Validate ArgString against known enum values.


Related Issues (Input Validation Pattern)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2-mediumCode quality & robustnessaudit-2026-03From March 2026 codebase auditcode-qualityCode quality improvementservice:game-server5stackgg/game-server service

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions