Enable .panel mode for iPhone SE #347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding .compact to displayModeForCurrentLayout to enable .panel mode to iPhone SE.
Contributor
|
The default behavior Is meant to mimic the iOS maps app. Does the iOS maps app do this in landscape on an iPhone SE? |
Author
|
It actually gets smaller instead of going to .panel mode, but I'm not sure if there is a mode that fits this case. |
ulmentflam
added a commit
that referenced
this pull request
Oct 9, 2020
Contributor
|
@gevartosky There is a mode that will fit this case now thanks to this PR! Checkout this branch and thanks for bringing up this issue! The next major version of Pulley will include support for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding .compact to displayModeForCurrentLayout to enable .panel mode to iPhone SE.
Currently, if you rotate an iPhone SE to landscape mode, the panel takes a lot of space from the already small screen of the device, covering other buttons of the application.