From b807afd6a61dbcae848d58a6de8b18b2aea230e6 Mon Sep 17 00:00:00 2001 From: Justin Kopepasah Date: Mon, 24 Jul 2017 21:19:40 +0900 Subject: [PATCH 1/3] Recommendations for workflow updates. --- .eslintrc | 1 + .gitignore | 1 + package.json | 17 ++++++++++++++++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 1880319..94ae914 100644 --- a/.eslintrc +++ b/.eslintrc @@ -13,6 +13,7 @@ "jQuery": true, "wp": false }, + "extends": 'wordpress', "rules": { "accessor-pairs": [2], "block-scoped-var": [2], diff --git a/.gitignore b/.gitignore index bdfda97..a121d1d 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ codecept.phar +node_modules diff --git a/package.json b/package.json index f9636ea..edd50dd 100644 --- a/package.json +++ b/package.json @@ -23,6 +23,11 @@ { "name": "Mike Crantea", "email": "mike.crantea@xwp.co" + }, + { + "name": "Justin Kopepasah", + "email": "justin.kopepasah@xwp.co", + "url": "https://kopepasah.com" } ], "license": "MIT", @@ -84,14 +89,23 @@ "stylelint-no-unsupported-browser-features" ], "rules": { + "string-quotes": "single", + "color-hex-length": "long", + "function-parentheses-space-inside": "always", + "function-url-quotes": "always", "at-rule-empty-line-before": [ "always", { "except": [ - "first-nested" + "first-nested", + "blockless-after-same-name-blockless" ], "ignore": [ "after-comment" + ], + "ignoreAtRules": [ + "else", + "elseif" ] } ], @@ -112,6 +126,7 @@ "babel-preset-env": "^1.6.0", "del": "^3.0.0", "eslint": "^4.3.0", + "eslint-config-wordpress": "^2.0.0", "eslint-loader": "^1.9.0", "eslint-plugin-compat": "^1.0.4", "gulp": "gulpjs/gulp.git#4.0", From 7c4b07a234a30484366e0e8b1693de92aeb855f4 Mon Sep 17 00:00:00 2001 From: Justin Kopepasah Date: Tue, 25 Jul 2017 14:48:04 +0900 Subject: [PATCH 2/3] Update quotes for JSON. --- .eslintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 94ae914..5c9d1ad 100644 --- a/.eslintrc +++ b/.eslintrc @@ -13,7 +13,7 @@ "jQuery": true, "wp": false }, - "extends": 'wordpress', + "extends": "wordpress", "rules": { "accessor-pairs": [2], "block-scoped-var": [2], From f63fc78c929b273790c63bc300595aac1908dc50 Mon Sep 17 00:00:00 2001 From: Justin Kopepasah Date: Tue, 25 Jul 2017 14:48:22 +0900 Subject: [PATCH 3/3] Set rules as null to not enforce. --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index edd50dd..c7232c2 100644 --- a/package.json +++ b/package.json @@ -90,8 +90,8 @@ ], "rules": { "string-quotes": "single", - "color-hex-length": "long", - "function-parentheses-space-inside": "always", + "color-hex-length": null, + "function-parentheses-space-inside": null, "function-url-quotes": "always", "at-rule-empty-line-before": [ "always",