From c1b2c97688302c92d62155f9329bafb1807333ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:47:56 +0100 Subject: [PATCH 01/22] Workflows check for file changes --- .github/workflows/build_and_test.yml | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index b8d7db10..b43cbf6b 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -4,11 +4,6 @@ on: pull_request: branches: - main - paths: - - '.github/workflows/build_and_test.yml' - - 'Sources/**' - - '!Sources/Runestone/Documentation.docc/**' - - 'Tests/**' concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true @@ -31,13 +26,24 @@ jobs: uses: actions/checkout@v4 with: submodules: recursive + - uses: dorny/paths-filter@v3 + id: changes + with: + filters: | + src: + - '.github/workflows/build_and_test.yml' + - 'Sources/**' + - '!Sources/Runestone/Documentation.docc/**' + - 'Tests/**' - name: Build + if: steps.changes.outputs.src == 'true' run: | xcodebuild build-for-testing\ -scheme Runestone\ -sdk iphonesimulator\ -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=latest" - name: Test + if: steps.changes.outputs.src == 'true' run: | xcodebuild test-without-building\ -scheme Runestone\ From f8ef5796649d1c265be4af009db1c072a1f5f71c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:48:53 +0100 Subject: [PATCH 02/22] Update build_example_project.yml --- .github/workflows/build_example_project.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_example_project.yml b/.github/workflows/build_example_project.yml index 25b03cc5..855f7aec 100644 --- a/.github/workflows/build_example_project.yml +++ b/.github/workflows/build_example_project.yml @@ -4,10 +4,6 @@ on: pull_request: branches: - main - paths: - - '.github/workflows/build_example_project.yml' - - 'Example/**' - - 'Sources/**' concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true @@ -32,7 +28,16 @@ jobs: uses: actions/checkout@v4 with: submodules: recursive + - uses: dorny/paths-filter@v3 + id: changes + with: + filters: | + src: + - '.github/workflows/build_example_project.yml' + - 'Example/**' + - 'Sources/**' - name: Build + if: steps.changes.outputs.src == 'true' run: | xcodebuild build\ -project Example/Example.xcodeproj\ From f3480a355ddda3fad7ba27005ace4943f3efb20c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:50:21 +0100 Subject: [PATCH 03/22] Update codeql.yml --- .github/workflows/codeql.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index db234f9d..0147e017 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -22,15 +22,26 @@ jobs: matrix: language: [ "swift", "c-cpp" ] steps: - - name: Checkout repository + - name: Checkout uses: actions/checkout@v4 with: submodules: recursive + - uses: dorny/paths-filter@v3 + id: changes + with: + filters: | + src: + - 'Example/**' + - 'Sources/**' + - 'Tests/**' + - 'UITests/**' - name: Initialize CodeQL + if: steps.changes.outputs.src == 'true' uses: github/codeql-action/init@v3 with: languages: ${{ matrix.language }} - name: Build + if: steps.changes.outputs.src == 'true' run: | xcodebuild\ -scheme Runestone\ @@ -38,5 +49,6 @@ jobs: -destination "platform=iOS Simulator,name=iPhone 15 Pro,OS=latest" - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v3 + if: steps.changes.outputs.src == 'true' with: category: "/language:${{matrix.language}}" From 5c2a1c1542ec25e56e6fe20fe1e615925d255699 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:50:45 +0100 Subject: [PATCH 04/22] Update swiftlint.yml --- .github/workflows/swiftlint.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index f91fbbe4..16c0febe 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -1,11 +1,7 @@ name: SwiftLint on: workflow_dispatch: {} - pull_request: - paths: - - '.github/workflows/swiftlint.yml' - - '.swiftlint.yml' - - '**/*.swift' + pull_request: {} concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true From 2ef9ab3b980101b1e4c18a472c50ac86b1a5552e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:59:28 +0100 Subject: [PATCH 05/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index b43cbf6b..8e319d6f 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -26,7 +26,8 @@ jobs: uses: actions/checkout@v4 with: submodules: recursive - - uses: dorny/paths-filter@v3 + - name: Check for changed files + uses: dorny/paths-filter@v3 id: changes with: filters: | From bb92bfb57f69811119bb4f58ccdc13d4ce1175d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:59:36 +0100 Subject: [PATCH 06/22] Update build_example_project.yml --- .github/workflows/build_example_project.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_example_project.yml b/.github/workflows/build_example_project.yml index 855f7aec..b362f81b 100644 --- a/.github/workflows/build_example_project.yml +++ b/.github/workflows/build_example_project.yml @@ -28,7 +28,8 @@ jobs: uses: actions/checkout@v4 with: submodules: recursive - - uses: dorny/paths-filter@v3 + - name: Check for changed files + uses: dorny/paths-filter@v3 id: changes with: filters: | From 1a55ed12a32f33e4ff6b93a68bd9f1438f772bd6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 12:59:45 +0100 Subject: [PATCH 07/22] Update codeql.yml --- .github/workflows/codeql.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 0147e017..c0f74bc6 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -26,7 +26,8 @@ jobs: uses: actions/checkout@v4 with: submodules: recursive - - uses: dorny/paths-filter@v3 + - name: Check for changed files + uses: dorny/paths-filter@v3 id: changes with: filters: | From 1eb2e443f4291e7ec93ca35e77253a5ec9de6767 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 13:06:31 +0100 Subject: [PATCH 08/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 8e319d6f..56acb20a 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -15,10 +15,12 @@ jobs: strategy: matrix: include: - - destination: iPhone 15 Pro - xcode: 15.2 - - destination: iPhone 14 Pro - xcode: 14.3.1 + - xcode: 15.2 + destination: iPhone 15 Pro + os: 17.2 + - xcode: 14.3.1 + destination: iPhone 14 Pro + os: 16.4 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer steps: @@ -42,11 +44,11 @@ jobs: xcodebuild build-for-testing\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=latest" + -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}" - name: Test if: steps.changes.outputs.src == 'true' run: | xcodebuild test-without-building\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=latest" + -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}" From fc5d24acf1616da4fecf3a190284732262b46ccc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 13:09:45 +0100 Subject: [PATCH 09/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 56acb20a..bdfb1b01 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -19,8 +19,8 @@ jobs: destination: iPhone 15 Pro os: 17.2 - xcode: 14.3.1 - destination: iPhone 14 Pro - os: 16.4 + destination: iPhone 15 Pro + os: 17.2 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer steps: From 5abd252832150faf5134b1eb3f6f64b70c41b452 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 13:15:17 +0100 Subject: [PATCH 10/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index bdfb1b01..cc68398f 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -16,11 +16,7 @@ jobs: matrix: include: - xcode: 15.2 - destination: iPhone 15 Pro - os: 17.2 - xcode: 14.3.1 - destination: iPhone 15 Pro - os: 17.2 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer steps: @@ -44,11 +40,11 @@ jobs: xcodebuild build-for-testing\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}" + -destination "platform=iOS Simulator,name=generic/platform=iOS Simulator,OS=latest" - name: Test if: steps.changes.outputs.src == 'true' run: | xcodebuild test-without-building\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}" + -destination "platform=iOS Simulator,name=generic/platform=iOS Simulator,OS=latest" From a8bcf28cfbb4bc1126e37805e9edfb4862a893e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:29:15 +0100 Subject: [PATCH 11/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index cc68398f..c77ef4d8 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -9,14 +9,18 @@ concurrency: cancel-in-progress: true jobs: build: - name: Build and test + name: Build and Test (Xcode ${{ matrix.xcode }}) runs-on: macos-14 continue-on-error: true strategy: matrix: include: - xcode: 15.2 + device: iPhone 15 Pro + os: 17.2 - xcode: 14.3.1 + device: iPhone 15 Pro + os: 17.2 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer steps: @@ -40,11 +44,11 @@ jobs: xcodebuild build-for-testing\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=generic/platform=iOS Simulator,OS=latest" + -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}" - name: Test if: steps.changes.outputs.src == 'true' run: | xcodebuild test-without-building\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=generic/platform=iOS Simulator,OS=latest" + -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}" From c29cdede15975d05d04c36dafa83a766adcb53f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:41:23 +0100 Subject: [PATCH 12/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index c77ef4d8..f33c888b 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -19,8 +19,8 @@ jobs: device: iPhone 15 Pro os: 17.2 - xcode: 14.3.1 - device: iPhone 15 Pro - os: 17.2 + device: iPhone 14 Pro + os: 16.4 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer steps: From 708c5349346a16893fbf998855a3969ed97eb63e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:45:01 +0100 Subject: [PATCH 13/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index f33c888b..aad7cc9d 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -41,14 +41,18 @@ jobs: - name: Build if: steps.changes.outputs.src == 'true' run: | + set -o pipefail\ xcodebuild build-for-testing\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}" + -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}"\ + | xcbeautify --renderer github-actions - name: Test if: steps.changes.outputs.src == 'true' run: | + set -o pipefail\ xcodebuild test-without-building\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}" + -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}"\ + | xcbeautify --renderer github-actions From 3ff819adccd7b9410eb31917eca72f8765f9a2f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:45:19 +0100 Subject: [PATCH 14/22] Update build_example_project.yml --- .github/workflows/build_example_project.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_example_project.yml b/.github/workflows/build_example_project.yml index b362f81b..5c1de326 100644 --- a/.github/workflows/build_example_project.yml +++ b/.github/workflows/build_example_project.yml @@ -40,8 +40,10 @@ jobs: - name: Build if: steps.changes.outputs.src == 'true' run: | + set -o pipefail\ xcodebuild build\ -project Example/Example.xcodeproj\ -scheme Example\ -sdk iphonesimulator\ - -destination "platform=${{ matrix.platform }},name=${{ matrix.destination }},OS=latest" + -destination "platform=${{ matrix.platform }},name=${{ matrix.destination }},OS=latest"\ + | xcbeautify --renderer github-actions From 7be7e4b1fc4072a6ffb7c982fc988e62fad2302a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:45:35 +0100 Subject: [PATCH 15/22] Update codeql.yml --- .github/workflows/codeql.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index c0f74bc6..788c245c 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -44,10 +44,12 @@ jobs: - name: Build if: steps.changes.outputs.src == 'true' run: | + set -o pipefail\ xcodebuild\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=iPhone 15 Pro,OS=latest" + -destination "platform=iOS Simulator,name=iPhone 15 Pro,OS=latest"\ + | xcbeautify --renderer github-actions - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v3 if: steps.changes.outputs.src == 'true' From 13cd82b6fb3cd0779348a9de40d5c145c4f651a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:47:04 +0100 Subject: [PATCH 16/22] Update build_example_project.yml --- .github/workflows/build_example_project.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_example_project.yml b/.github/workflows/build_example_project.yml index 5c1de326..b31475aa 100644 --- a/.github/workflows/build_example_project.yml +++ b/.github/workflows/build_example_project.yml @@ -9,7 +9,7 @@ concurrency: cancel-in-progress: true jobs: build: - name: Build example project + name: Build Example Project (Xcode ${{ matrix.xcode }}) runs-on: macos-14 continue-on-error: true strategy: From ca43e82abab23f04c7b90522813d297ffff6da51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:47:45 +0100 Subject: [PATCH 17/22] Update build_and_test.yml --- .github/workflows/build_and_test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index aad7cc9d..2907cfb3 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -16,10 +16,10 @@ jobs: matrix: include: - xcode: 15.2 - device: iPhone 15 Pro + destination: iPhone 15 Pro os: 17.2 - xcode: 14.3.1 - device: iPhone 14 Pro + destination: iPhone 14 Pro os: 16.4 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer @@ -45,7 +45,7 @@ jobs: xcodebuild build-for-testing\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}"\ + -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}"\ | xcbeautify --renderer github-actions - name: Test if: steps.changes.outputs.src == 'true' @@ -54,5 +54,5 @@ jobs: xcodebuild test-without-building\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=${{ matrix.device }},OS=${{ matrix.os }}"\ + -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}"\ | xcbeautify --renderer github-actions From 5ea16a6e6b96fddaeb1e20e7975e0429e0a09a1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:48:34 +0100 Subject: [PATCH 18/22] Update build_example_project.yml --- .github/workflows/build_example_project.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build_example_project.yml b/.github/workflows/build_example_project.yml index b31475aa..c74e9056 100644 --- a/.github/workflows/build_example_project.yml +++ b/.github/workflows/build_example_project.yml @@ -15,12 +15,12 @@ jobs: strategy: matrix: include: - - platform: iOS Simulator + - xcode: 15.2 destination: iPhone 15 Pro - xcode: 15.2 - - platform: iOS Simulator + os: 17.2 + - xcode: 14.3.1 destination: iPhone 14 Pro - xcode: 14.3.1 + os: 16.4 env: DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer steps: @@ -45,5 +45,5 @@ jobs: -project Example/Example.xcodeproj\ -scheme Example\ -sdk iphonesimulator\ - -destination "platform=${{ matrix.platform }},name=${{ matrix.destination }},OS=latest"\ + -destination "platform=iOS Simulator,name=${{ matrix.destination }},OS=${{ matrix.os }}"\ | xcbeautify --renderer github-actions From b0c75de1ca5a3ed508a334cb8698797d86bc2800 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:49:58 +0100 Subject: [PATCH 19/22] Update codeql.yml --- .github/workflows/codeql.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 788c245c..3302aee6 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -11,6 +11,8 @@ concurrency: cancel-in-progress: true env: DEVELOPER_DIR: /Applications/Xcode_15.0.1.app/Contents/Developer + XCODEBUILD_DESTINATION: iPhone 15 Pro + XCODEBUILD_OS: 17.2 jobs: analyze: name: Analyze @@ -48,7 +50,7 @@ jobs: xcodebuild\ -scheme Runestone\ -sdk iphonesimulator\ - -destination "platform=iOS Simulator,name=iPhone 15 Pro,OS=latest"\ + -destination "platform=iOS Simulator,name=${{ env.XCODEBUILD_DESTINATION }},OS=${{ env.XCODEBUILD_OS }}"\ | xcbeautify --renderer github-actions - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v3 From aed5782b894d8e2d5ff798a51668639338b866d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:50:06 +0100 Subject: [PATCH 20/22] Update codeql.yml --- .github/workflows/codeql.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 3302aee6..c5a0e6fb 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -10,7 +10,6 @@ concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true env: - DEVELOPER_DIR: /Applications/Xcode_15.0.1.app/Contents/Developer XCODEBUILD_DESTINATION: iPhone 15 Pro XCODEBUILD_OS: 17.2 jobs: From a5c23152c6989b33c3b15adeeb2f7d36f1b7b47d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:50:25 +0100 Subject: [PATCH 21/22] Update deploy_documentation.yml --- .github/workflows/deploy_documentation.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/deploy_documentation.yml b/.github/workflows/deploy_documentation.yml index db45fc36..0ff824ed 100644 --- a/.github/workflows/deploy_documentation.yml +++ b/.github/workflows/deploy_documentation.yml @@ -8,8 +8,6 @@ permissions: concurrency: group: "pages" cancel-in-progress: true -env: - DEVELOPER_DIR: /Applications/Xcode_15.2.app/Contents/Developer jobs: build: runs-on: macos-14 From 3ed56ee1d219ae36b3b469a5d0bdabd35b0f8bba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20B=2E=20St=C3=B8vring?= Date: Fri, 23 Feb 2024 14:51:10 +0100 Subject: [PATCH 22/22] Update deploy_documentation.yml --- .github/workflows/deploy_documentation.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy_documentation.yml b/.github/workflows/deploy_documentation.yml index 0ff824ed..693d6d3c 100644 --- a/.github/workflows/deploy_documentation.yml +++ b/.github/workflows/deploy_documentation.yml @@ -1,6 +1,6 @@ name: Deploy Documentation on: - workflow_dispatch: + workflow_dispatch: {} permissions: contents: read pages: write