Skip to content

Add mkdir_p to FileUtils.install #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 6 commits into from
Feb 10, 2023
Merged

Add mkdir_p to FileUtils.install #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e398562
Add mkdir_p to FileUtils.install
satmandu Jan 10, 2023
7bdce7f
Adjust raise message.
satmandu Jan 10, 2023
b900c68
adjust raise language
satmandu Jan 10, 2023
b3d33fa
handle trailing slash in dest
satmandu Jan 11, 2023
f0ab90f
simplify
satmandu Jan 11, 2023
1e32bd5
Add tests
satmandu Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/fileutils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,7 +1642,13 @@ def install(src, dest, mode: nil, owner: nil, group: nil, preserve: nil,
st = File.stat(s)
unless File.exist?(d) and compare_file(s, d)
remove_file d, true
copy_file s, d
if d.end_with?('/')
mkdir_p d
copy_file s, d + File.basename(s)
else
mkdir_p File.expand_path('..', d)
copy_file s, d
end
File.utime st.atime, st.mtime, d if preserve
File.chmod fu_mode(mode, st), d if mode
File.chown uid, gid, d if uid or gid
Expand Down
8 changes: 8 additions & 0 deletions test/fileutils/test_fileutils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,6 +1237,14 @@ def test_install_pathname
install Pathname.new('tmp/a'), 'tmp/b'
rm_f 'tmp/a'; touch 'tmp/a'
install Pathname.new('tmp/a'), Pathname.new('tmp/b')
my_rm_rf 'tmp/new_dir_end_with_slash'
install Pathname.new('tmp/a'), 'tmp/new_dir_end_with_slash/'
my_rm_rf 'tmp/new_dir_end_with_slash'
my_rm_rf 'tmp/new_dir'
install Pathname.new('tmp/a'), 'tmp/new_dir/a'
my_rm_rf 'tmp/new_dir'
install Pathname.new('tmp/a'), 'tmp/new_dir/new_dir_end_with_slash/'
my_rm_rf 'tmp/new_dir'
rm_f 'tmp/a'
touch 'tmp/a'
touch 'tmp/b'
Expand Down