From b1dda9065068882c49ccff78e85c83d31ab30b3e Mon Sep 17 00:00:00 2001 From: A7med3bdulBaset Date: Wed, 5 Jul 2023 12:02:23 +0300 Subject: [PATCH 1/5] add condition to just when branch is not equal to main --- .github/workflows/analyze_comment.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index 5a3047cfc..cfb9b518d 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -10,8 +10,9 @@ jobs: comment: runs-on: ubuntu-latest if: > - ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' }} + github.event.workflow_run.conclusion == 'success' && + github.event.workflow_run.name == 'Analyze Bundle' && + github.event.workflow_run.head_branch != 'main' steps: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@v2 From cf442d198c0468c0b6a1721519dda121e2295ef4 Mon Sep 17 00:00:00 2001 From: A7med3bdulBaset Date: Wed, 5 Jul 2023 12:16:30 +0300 Subject: [PATCH 2/5] test: add condition --- .github/workflows/analyze_comment.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index 5a3047cfc..0a6713a05 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -11,7 +11,8 @@ jobs: runs-on: ubuntu-latest if: > ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' }} + github.event.workflow_run.conclusion == 'success' && + github.event.workflow_run.head_branch != 'main' }} steps: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@v2 From 98e9e73262f110846cf52a9f77302629a49120a5 Mon Sep 17 00:00:00 2001 From: Ahmed Abdelbaset Date: Wed, 5 Jul 2023 12:29:36 +0300 Subject: [PATCH 3/5] revert --- .github/workflows/analyze_comment.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index 0a6713a05..5a3047cfc 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -11,8 +11,7 @@ jobs: runs-on: ubuntu-latest if: > ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' && - github.event.workflow_run.head_branch != 'main' }} + github.event.workflow_run.conclusion == 'success' }} steps: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@v2 From 47af261a6152fc637dfd1b11f78433b0263512fa Mon Sep 17 00:00:00 2001 From: A7med3bdulBaset Date: Fri, 14 Jul 2023 02:36:31 +0300 Subject: [PATCH 4/5] reference/react-dom/index --- src/content/reference/react-dom/index.md | 29 ++++++++++++------------ 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/content/reference/react-dom/index.md b/src/content/reference/react-dom/index.md index 5b2648c18..2704e81a4 100644 --- a/src/content/reference/react-dom/index.md +++ b/src/content/reference/react-dom/index.md @@ -4,7 +4,7 @@ title: React DOM APIs -The `react-dom` package contains methods that are only supported for the web applications (which run in the browser DOM environment). They are not supported for React Native. +تحتوي حزمة `react-dom` الوظائف المدعومة لتطبيقات الويب فقط (التي تعمل في بيئة المستعرض DOM). أي أنها غير مدعومة لـ React Native. @@ -12,32 +12,31 @@ The `react-dom` package contains methods that are only supported for the web app ## APIs {/*apis*/} -These APIs can be imported from your components. They are rarely used: +هذه الوظائف يمكن استيرادها في مكوناتك. لكن نادراً ما يتم استخدامها: -* [`createPortal`](/reference/react-dom/createPortal) lets you render child components in a different part of the DOM tree. -* [`flushSync`](/reference/react-dom/flushSync) lets you force React to flush a state update and update the DOM synchronously. +* تتيح لك [`createPortal`](/reference/react-dom/createPortal) تقديم مكونات فرعية في جزء مختلف من شجرة DOM. +* تتيح لك [`flushSync`](/reference/react-dom/flushSync) إجبار React على تفريغ تحديث الحالة وتحديث DOM بشكل متزامن. --- -## Entry points {/*entry-points*/} +## نقطة البداية {/*entry-points*/} -The `react-dom` package provides two additional entry points: +تقدم حزمة `react-dom` نقطتي بداية إضافيتين: -* [`react-dom/client`](/reference/react-dom/client) contains APIs to render React components on the client (in the browser). -* [`react-dom/server`](/reference/react-dom/server) contains APIs to render React components on the server. +* تحتوي [`react-dom/client`](/reference/react-dom/client) على وظائف لتصيير مكونات React على العميل (في المستعرض). +* تحتوي [`react-dom/server`](/reference/react-dom/server) على وظائف لتصيير مكونات React على الخادم. --- -## Deprecated APIs {/*deprecated-apis*/} +## وظائف ملغاه {/*deprecated-apis*/} -These APIs will be removed in a future major version of React. +ستتم إزالة هذه الوظائف في إصدار رئيسي مستقبلي من React. -* [`findDOMNode`](/reference/react-dom/findDOMNode) finds the closest DOM node corresponding to a class component instance. -* [`hydrate`](/reference/react-dom/hydrate) mounts a tree into the DOM created from server HTML. Deprecated in favor of [`hydrateRoot`](/reference/react-dom/client/hydrateRoot). -* [`render`](/reference/react-dom/render) mounts a tree into the DOM. Deprecated in favor of [`createRoot`](/reference/react-dom/client/createRoot). -* [`unmountComponentAtNode`](/reference/react-dom/unmountComponentAtNode) unmounts a tree from the DOM. Deprecated in favor of [`root.unmount()`.](/reference/react-dom/client/createRoot#root-unmount) - +* تجد [`findDOMNode`](/reference/react-dom/findDOMNode) أقرب عنصر DOM تتوافق مع مثيل مكون `class` component. +* تقوم [`hydrate`](/reference/react-dom/hydrate) بتركيب شجرة في DOM التي تم إنشاؤها من HTML الخادم. مهجور لصالح [`hydrateRoot`](/reference/react-dom/client/hydrateRoot). +* تقوم [`render`](/reference/react-dom/render) بتركيب شجرة في DOM. مهجور لصالح [`createRoot`](/reference/react-dom/client/createRoot). +* تقوم [`unmountComponentAtNode`](/reference/react-dom/unmountComponentAtNode) بإلغاء تركيب شجرة من DOM. مهجور لصالح [`root.unmount()`.](/reference/react-dom/client/createRoot#root-unmount) From 621386edb685c4eb81846cd92b70d89c4ee256c4 Mon Sep 17 00:00:00 2001 From: A7med3bdulBaset Date: Fri, 14 Jul 2023 03:06:25 +0300 Subject: [PATCH 5/5] review --- src/content/reference/react-dom/index.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/content/reference/react-dom/index.md b/src/content/reference/react-dom/index.md index 2704e81a4..06dca9952 100644 --- a/src/content/reference/react-dom/index.md +++ b/src/content/reference/react-dom/index.md @@ -4,7 +4,7 @@ title: React DOM APIs -تحتوي حزمة `react-dom` الوظائف المدعومة لتطبيقات الويب فقط (التي تعمل في بيئة المستعرض DOM). أي أنها غير مدعومة لـ React Native. +تحتوي حزمة `react-dom` على الوظائف المدعومة لتطبيقات الويب فقط (التي تعمل في بيئة المتصفح DOM). أي أنها غير مدعومة لـ React Native. @@ -19,12 +19,12 @@ title: React DOM APIs --- -## نقطة البداية {/*entry-points*/} +## نقاط البداية {/*entry-points*/} تقدم حزمة `react-dom` نقطتي بداية إضافيتين: -* تحتوي [`react-dom/client`](/reference/react-dom/client) على وظائف لتصيير مكونات React على العميل (في المستعرض). -* تحتوي [`react-dom/server`](/reference/react-dom/server) على وظائف لتصيير مكونات React على الخادم. +* تحتوي [`react-dom/client`](/reference/react-dom/client) على وظائف لتصيير مكونات React في جانب العميل (في المتصفح). +* تحتوي [`react-dom/server`](/reference/react-dom/server) على وظائف لتصيير مكونات React في الخادم. --- @@ -36,7 +36,7 @@ title: React DOM APIs -* تجد [`findDOMNode`](/reference/react-dom/findDOMNode) أقرب عنصر DOM تتوافق مع مثيل مكون `class` component. -* تقوم [`hydrate`](/reference/react-dom/hydrate) بتركيب شجرة في DOM التي تم إنشاؤها من HTML الخادم. مهجور لصالح [`hydrateRoot`](/reference/react-dom/client/hydrateRoot). +* تجد [`findDOMNode`](/reference/react-dom/findDOMNode) أقرب عنصر DOM يتوافق مع مثيل مكون `class`. +* تقوم [`hydrate`](/reference/react-dom/hydrate) بتركيب شجرة في DOM التي تم إنشاؤها من HTML الذي تم تصييره في الخادم. مهجور لصالح [`hydrateRoot`](/reference/react-dom/client/hydrateRoot). * تقوم [`render`](/reference/react-dom/render) بتركيب شجرة في DOM. مهجور لصالح [`createRoot`](/reference/react-dom/client/createRoot). * تقوم [`unmountComponentAtNode`](/reference/react-dom/unmountComponentAtNode) بإلغاء تركيب شجرة من DOM. مهجور لصالح [`root.unmount()`.](/reference/react-dom/client/createRoot#root-unmount)