Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

Commit bd78ad6

Browse files
authored
fix(peer-dependencies): adjust peer dependencies for Angular 8 (#462)
Note: PatternFly-ng is not compatible with ngx-bootstrap 3.3.0 For Angular 8, the following must be added to the options of agular.json ``` "options": { "preserveSymlinks": true, ``` See: https://stackoverflow.com/questions/53833985/no-provider-for-viewcontainerref-while-using-ng-packagr-component
1 parent 06e46d7 commit bd78ad6

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ Welcome to PatternFly-Ng. This is a library of common Angular components for us
66
- API Docs: http://www.patternfly.org/patternfly-ng/
77
- Build Status: https://travis-ci.org/patternfly/patternfly-ng.svg?branch=master
88

9-
109
### Using PatternFly-ng In Your Application
1110

1211
This example demonstrates using the Angular-cli to get started with PatternFly-ng
@@ -54,7 +53,6 @@ import { ToastNotificationModule } from 'patternfly-ng';
5453

5554
```json
5655
"styles": [
57-
5856
"./node_modules/patternfly/dist/css/patternfly.min.css",
5957
"./node_modules/patternfly/dist/css/patternfly-additions.min.css",
6058
"./node_modules/patternfly-ng/dist/css/patternfly-ng.min.css",
@@ -72,6 +70,13 @@ import { ToastNotificationModule } from 'patternfly-ng';
7270
</pfng-toast-notification>
7371
```
7472

73+
5. For Angular 8, open `angular.json` and insert the following into the options array
74+
75+
```
76+
"options": {
77+
"preserveSymlinks": true,
78+
```
79+
7580
### Optional Dependencies
7681

7782
1. To enable table drag and drop, add dragula.min.css from the ng2-dragula package

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@
9393
"npm": ">=5.6.0"
9494
},
9595
"peerDependencies": {
96-
"@angular/common": "<7.0.0",
97-
"@angular/compiler": "<7.0.0",
98-
"@angular/core": "<7.0.0",
99-
"@angular/forms": "<7.0.0",
96+
"@angular/common": "<8.0.0",
97+
"@angular/compiler": "<8.0.0",
98+
"@angular/core": "<8.0.0",
99+
"@angular/forms": "<8.0.0",
100100
"typescript": "^2.9.2",
101101
"rxjs": "^6.2.2"
102102
},
@@ -108,7 +108,7 @@
108108
"@swimlane/ngx-datatable": "^13.0.0",
109109
"c3": "^0.4.15",
110110
"ng2-dragula": "^1.5.0",
111-
"ngx-bootstrap": "^3.0.0"
111+
"ngx-bootstrap": "^3.0.0 || <3.3.0"
112112
},
113113
"devDependencies": {
114114
"@angular-devkit/core": "0.7.1",

0 commit comments

Comments
 (0)